Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fast-reboot]: Refactor fast-reboot script. Store the dumps in /host #208

Merged
merged 1 commit into from
Feb 23, 2018
Merged

[Fast-reboot]: Refactor fast-reboot script. Store the dumps in /host #208

merged 1 commit into from
Feb 23, 2018

Conversation

pavel-shirshov
Copy link
Contributor

- What I did

  1. Refactor fast-reboot script
  2. Store the dumps in /host directory to better work with NOS-SONiC updates

- How I did it
Modify fast-reboot and fast-reboot.py to better serve our needs

- How to verify it

  1. Run mkdir your_dir; sudo /usr/bin/fast-reboot-dump.py your_dir to find the dumps in your_dir
  2. Run sudo fast-reboot to find the fast-reboot working

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

-->

@pavel-shirshov pavel-shirshov self-assigned this Feb 21, 2018
@pavel-shirshov pavel-shirshov mentioned this pull request Feb 21, 2018
Merged
@lguohan
Copy link
Contributor

lguohan commented Feb 22, 2018

is this also for sonic to sonic upgrade?

@pavel-shirshov
Copy link
Contributor Author

Yes

lguohan
lguohan reviewed Feb 23, 2018
View reviewed changes
scripts/fast-reboot-dump.py
generate_default_route_entries('/tmp/default_routes.json')
root_dir = '/tmp'
if len(sys.argv) > 1 and os.path.isdir(sys.argv[1]):
root_dir = sys.argv[1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to use argparser to add option, easy to use, give you options, and helps.

https://docs.python.org/2/howto/argparse.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. In this case the script is used from another script only. So I decided to use fastest method.

@pavel-shirshov pavel-shirshov merged commit 461470b into sonic-net:master Feb 23, 2018
@pavel-shirshov pavel-shirshov deleted the pavelsh/fr_script_changes branch February 23, 2018 19:34
zhenggen-xu added a commit to zhenggen-xu/sonic-utilities that referenced this pull request Jun 6, 2018
@zhenggen-xu
Merge branch 'github'
473c9dd 
            RB=1288101
            G=lnos-reviewers
            R=ntrianta,pmao,rmolina,sfardeen,zxu

* github:
  [acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
  [show] Rename 'show session' to 'show mirror session' (sonic-net#235)
  [pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
  [queuestat] add python CLI tool to show queue counters
  [acl-loader] Not to crash upon invalid rule (sonic-net#232)
  Show FDB type in fdbshow/show mac (sonic-net#231)
  [show] add 'show runningconfiguration all' subcommand (sonic-net#230)
  [reboot scripts] remove -t option in docker exec commands (sonic-net#228)
  [reboot] reduce stop service to only stop syncd (sonic-net#223)
  [crm]: Fix failures in CLI show commands (sonic-net#221)
  [Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
  add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
  [config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
  [PFCWD]: set default configuration when enabled by default (sonic-net#213)
  Add fast-reboot support for Aboot based images (sonic-net#214)
  sonic-utilities: Format show vlan config output (sonic-net#210)
  [AAA] Support login(ascii) authentication type (sonic-net#217)
  [sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
  [Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2  (sonic-net#211)
  Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
  Find correct opennsl module name before stopping it (sonic-net#207)
  [crm]: Add utility for CRM configuration (sonic-net#187)
  [reboot] update reboot script to retrieve platform with new format (sonic-net#206)
  Adapt to config engine change to load platform info properly (sonic-net#205)
  [config] Add qos clear and qos reload support (sonic-net#204)
  Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
  [acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
  [pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
  [acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
  [config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
  Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
  [TACACS+]: Fix aaa show error without configuration (sonic-net#191)
  'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
  [sonic-clear] add a clear fdb command (sonic-net#186)
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
@vdahiya12
[202012][submodule] update sonic-platform-common and sonic-platform-d…
b82abd8 
…aemons (#8607)


This PR updates the following commits in sonic-platform-common
9d2e7d5 Add y-cable driver for simulated mux (sonic-net#213)
e3e8f09 [Y-Cable][Broadcom] Broadcom implementation of YCable class which inherits from YCableBase required for Y-Cable API's in sonic-platform-daemons (sonic-net#208)

This PR updates the following commits in sonic-platform-daemons

ebc4f3f [Y-Cable] create unknown entries for mux_cable when there is a cable present but module definition is not present/invalid module
b10c417 [xcvrd] initial support for integrating vendor specfic class objects for calling Y-Cable API's inside xcvrd (sonic-net#197) (sonic-net#213)
f3fc1ea [y-cable] fix for logging the xcvrd metrics before writing the state to the State-DB (sonic-net#208)


Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
@vdahiya12
[Y-Cable][Broadcom] Broadcom implementation of YCable class which inh…
c17c370 
…erits from YCableBase required for Y-Cable API's in sonic-platform-daemons (sonic-net#208)

This PR adds support for YCable class required for platform-daemons to use the YCable API's for Broadcom.

Description
Basically a vendor specific implementation of abstract YCableBase class .
detailed design discussion can be found https://github.com/Azure/SONiC/pull/757/files

Motivation and Context
Required for transitioning to vendor agnostic API's to be called by xcvrd, so that all types of cables can be called.

How Has This Been Tested?
Ran the changes on Arista7050cx3 switch, making changes inside the container.


Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@pavel-shirshov pavel-shirshov

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pavel-shirshov @lguohan