Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor #195

Merged
merged 1 commit into from
Jan 27, 2018
Merged

'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor #195

merged 1 commit into from
Jan 27, 2018

Conversation

jleveque
Copy link
Contributor

- What I did

  • Previously, if multiple BGP sessions existed for a neighbor (e.g., an IPv4 session and an IPv6 session), calling config bgp shutdown neighbor <hostname> would only shut down the first session it located in ConfigDB. This PR will now cause the command to shut down all BGP sessions associated with that neighbor. (The same is true of config bgp startup neighbor <hostname>)

  • Also fix a bug where passing config bgp [shutdown|startup] neighbor <ip_address> would fail to locate a neighbor with that IP address if the IP address passed was an IPv6 address containing lowercase alphabet characters. IPv6 addresses are stored in ConfigDB with all uppercase alphabet characters and the lookup is case-sensitive. Now converting all IP addresses to uppercase before performing ConfigDB operations with them.

- Previous command output (if the output of a command-line utility has changed)

root@sonic:~# config bgp shutdown neighbor ARISTA01T1       
Shutting down BGP session with neighbor 10.0.0.57...

root@sonic:~# config bgp startup neighbor ARISTA01T1       
Starting up BGP session with neighbor 10.0.0.57...

- New command output (if the output of a command-line utility has changed)

root@sonic:~# config bgp shutdown neighbor ARISTA01T1       
Shutting down BGP session with neighbor 10.0.0.57...
Shutting down BGP session with neighbor FC00::72...

root@sonic:~# config bgp startup neighbor ARISTA01T1       
Starting up BGP session with neighbor 10.0.0.57...
Starting up BGP session with neighbor FC00::72...

@jleveque jleveque added the Bug label Jan 27, 2018
@jleveque jleveque self-assigned this Jan 27, 2018
@jleveque jleveque merged commit f07fa89 into sonic-net:master Jan 27, 2018
@jleveque jleveque deleted the fix_config_bgp_shut_start branch January 27, 2018 02:40
zhenggen-xu added a commit to zhenggen-xu/sonic-utilities that referenced this pull request Jun 6, 2018
@zhenggen-xu
Merge branch 'github'
473c9dd 
            RB=1288101
            G=lnos-reviewers
            R=ntrianta,pmao,rmolina,sfardeen,zxu

* github:
  [acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
  [show] Rename 'show session' to 'show mirror session' (sonic-net#235)
  [pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
  [queuestat] add python CLI tool to show queue counters
  [acl-loader] Not to crash upon invalid rule (sonic-net#232)
  Show FDB type in fdbshow/show mac (sonic-net#231)
  [show] add 'show runningconfiguration all' subcommand (sonic-net#230)
  [reboot scripts] remove -t option in docker exec commands (sonic-net#228)
  [reboot] reduce stop service to only stop syncd (sonic-net#223)
  [crm]: Fix failures in CLI show commands (sonic-net#221)
  [Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
  add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
  [config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
  [PFCWD]: set default configuration when enabled by default (sonic-net#213)
  Add fast-reboot support for Aboot based images (sonic-net#214)
  sonic-utilities: Format show vlan config output (sonic-net#210)
  [AAA] Support login(ascii) authentication type (sonic-net#217)
  [sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
  [Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2  (sonic-net#211)
  Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
  Find correct opennsl module name before stopping it (sonic-net#207)
  [crm]: Add utility for CRM configuration (sonic-net#187)
  [reboot] update reboot script to retrieve platform with new format (sonic-net#206)
  Adapt to config engine change to load platform info properly (sonic-net#205)
  [config] Add qos clear and qos reload support (sonic-net#204)
  Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
  [acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
  [pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
  [acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
  [config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
  Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
  [TACACS+]: Fix aaa show error without configuration (sonic-net#191)
  'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
  [sonic-clear] add a clear fdb command (sonic-net#186)
vdahiya12 added a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
@vdahiya12
[xcvrd] add debug logs for y_cable change events/probes (sonic-net#195)
2d2749a 
This PR adds support for logging required in debugging events for change/probe requests received by xcvrd from swss and linkmgr into state DB.
a typical log would look like this:

Jun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: trying to enable/disable debug logs
Jun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: received an event for port transition Ethernet4
Jun 17 05:55:39.302575 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: xcvrd trying to transition port Ethernet4 from standby to active
Jun 17 05:55:39.307872 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: Successful in toggling mux to ToR A for port 2

where both probe events and change events are logged inside xcvrd.

Motivation and Context
This is required for xcvrd to log the events which it receives from other modules when we want to see the completion of events
as to what triggered the event and at which stage it failed without restarting pmon/xcvrd



Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
@sujinmkang
Add to check pcie configuration revision to get the right configurati…
f57fee4 
…on. (sonic-net#195)

Platform vendor can add their own logic to determine the pcie
conifiguration revision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@taoyl-ms taoyl-ms Awaiting requested review from taoyl-ms

Assignees

@jleveque jleveque

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jleveque @lguohan