Add FEC correctable and uncorrectable port stats #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
please add -v option to print out those column, not sure we should print them out by default. |
will add new option "fec-errors" |
Signed-off-by: Prince George <prgeor@microsoft.com>
Signed-off-by: Prince George <prgeor@microsoft.com>
|
This pull request introduces 1 alert when merging 397df8b into 6de18a1 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 419f739 into c6794b5 - view on LGTM.com new alerts:
|
lguohan
previously approved these changes
Aug 3, 2022
lguohan
approved these changes
Aug 4, 2022
7 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
Update sonic-utilities submodule pointer to include the following: * Fix GCU bug when backend service modifying config ([sonic-net#2295](sonic-net/sonic-utilities#2295)) * Fix issues for sonic_installer upgrade-docker and sonic_installer rollback-docker ([sonic-net#2278](sonic-net/sonic-utilities#2278)) * [crm] add checking for CRM interval range ([sonic-net#2293](sonic-net/sonic-utilities#2293)) * Fix the issue that sonic_platform is not installed on vs image ([sonic-net#2300](sonic-net/sonic-utilities#2300)) * Add FEC correctable and uncorrectable port stats ([sonic-net#2027](sonic-net/sonic-utilities#2027)) * Add CLI to configure YANG config validation ([sonic-net#2147](sonic-net/sonic-utilities#2147)) * Add override testcase to verify removal ([sonic-net#2288](sonic-net/sonic-utilities#2288)) * Fix version in db_migrator for ([sonic-net#2289](sonic-net/sonic-utilities#2289)) * [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB ([sonic-net#2223](sonic-net/sonic-utilities#2223)) * Transfer organization from Azure to sonic-net ([sonic-net#2284](sonic-net/sonic-utilities#2284)) * [watermarkstat] Fix CLI script for unconfigured PG counters ([sonic-net#2239](sonic-net/sonic-utilities#2239)) * Improve the way to check port type of RJ45 port ([sonic-net#2249](sonic-net/sonic-utilities#2249)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
* Add FEC correctable and uncorrectable port stats Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failures Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failure * Added separate command for fec stats * Fix test failure * Fix LGTM warning * Improve code coveraged
lukasstockner
pushed a commit
to genesiscloud/sonic-utilities
that referenced
this pull request
Mar 14, 2023
* Add FEC correctable and uncorrectable port stats Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failures Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failure * Added separate command for fec stats * Fix test failure * Fix LGTM warning * Improve code coveraged
lukasstockner
pushed a commit
to genesiscloud/sonic-utilities
that referenced
this pull request
Mar 31, 2023
* Add FEC correctable and uncorrectable port stats Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failures Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failure * Added separate command for fec stats * Fix test failure * Fix LGTM warning * Improve code coveraged
lukasstockner
pushed a commit
to genesiscloud/sonic-utilities
that referenced
this pull request
Apr 2, 2023
* Add FEC correctable and uncorrectable port stats Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failures Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failure * Added separate command for fec stats * Fix test failure * Fix LGTM warning * Improve code coveraged
|
@yxieca can you help cherry pick this to 202205? |
|
@StormLiangMS can you help cherry pick this to 202305? |
yxieca
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Add FEC correctable and uncorrectable port stats Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failures Signed-off-by: Prince George <prgeor@microsoft.com> * fix pytest failure * Added separate command for fec stats * Fix test failure * Fix LGTM warning * Improve code coveraged
|
@prgeor cherry pick to 202305 got conflicts, could you resubmit PR to 202305? |
|
@StormLiangMS the code changes are already in 202305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO: 24531597
Signed-off-by: Prince George prgeor@microsoft.com
Added command line option to see FEC correctable, uncorrectable errors and symbol errors(aggregate of all lanes)
New command output (if the output of a command-line utility has changed)