Add CLI to configure YANG config validation #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 11335b2 into 7a06457 - view on LGTM.com new alerts:
|
wen587
reviewed
Jul 13, 2022
config/yang_validation_service.py
Outdated
| def validate_config_db_config(self, config_json): | ||
| sy = self.create_sonic_yang_with_loaded_models() | ||
| try: | ||
| tmp_config_json = copy.deepcopy(config_json) |
wen587
reviewed
Jul 18, 2022
config/main.py
Outdated
| ctx.fail("Invalid configuration based on PortChannel YANG model") | ||
| else: | ||
| db.set_entry('PORTCHANNEL', portchannel_name, fvs) | ||
|
|
There was a problem hiding this comment.
It seems we always validate yang no matter yang_config_validation is enabled or not?
Maybe we are supposed to validate it based on the yang_config_validation?
qiluo-msft
changed the title
qiluo-msft
reviewed
Jul 27, 2022
| # | ||
| @config.command('yang_config_validation') | ||
| @click.argument('yang_config_validation', metavar='<enable|disable>', required=True) | ||
| def yang_config_validation(yang_config_validation): |
added 3 commits
July 29, 2022 22:05
|
LGTM |
qiluo-msft
approved these changes
Aug 3, 2022
7 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
Update sonic-utilities submodule pointer to include the following: * Fix GCU bug when backend service modifying config ([sonic-net#2295](sonic-net/sonic-utilities#2295)) * Fix issues for sonic_installer upgrade-docker and sonic_installer rollback-docker ([sonic-net#2278](sonic-net/sonic-utilities#2278)) * [crm] add checking for CRM interval range ([sonic-net#2293](sonic-net/sonic-utilities#2293)) * Fix the issue that sonic_platform is not installed on vs image ([sonic-net#2300](sonic-net/sonic-utilities#2300)) * Add FEC correctable and uncorrectable port stats ([sonic-net#2027](sonic-net/sonic-utilities#2027)) * Add CLI to configure YANG config validation ([sonic-net#2147](sonic-net/sonic-utilities#2147)) * Add override testcase to verify removal ([sonic-net#2288](sonic-net/sonic-utilities#2288)) * Fix version in db_migrator for ([sonic-net#2289](sonic-net/sonic-utilities#2289)) * [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB ([sonic-net#2223](sonic-net/sonic-utilities#2223)) * Transfer organization from Azure to sonic-net ([sonic-net#2284](sonic-net/sonic-utilities#2284)) * [watermarkstat] Fix CLI script for unconfigured PG counters ([sonic-net#2239](sonic-net/sonic-utilities#2239)) * Improve the way to check port type of RJ45 port ([sonic-net#2249](sonic-net/sonic-utilities#2249)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
**- What I did** Add CLI to configure YANG config validation mode `config yang_config_validation <enable|disable>` **- How I did it** Add a CLI script that writes the configuration of YANG config validation enable/disable into CONFIG_DB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add CLI to configure YANG config validation mode
config yang_config_validation <enable|disable>- How I did it
Add a CLI script that writes the configuration of YANG config validation enable/disable into CONFIG_DB
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)