Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBH] Implement Edit Flows #2093

Merged
merged 1 commit into from Mar 30, 2022

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Mar 4, 2022

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects.
PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing.

HLD: sonic-net/SONiC#909

What I did

  • Implemented Edit Flows in scope of PBH enhancement

How I did it

  • Implementation is done according to the PBH HLD

How to verify it

  • N/A

Previous command output (if the output of a command-line utility has changed)

  • N/A

New command output (if the output of a command-line utility has changed)

  • N/A

@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2022

This pull request introduces 1 alert when merging 8df89490d46d4eac866080b30cf66b32c9cf9b10 into 47c243e - view on LGTM.com

new alerts:

  • 1 for Unused import

@nazariig
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

@anish-n please have a look

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
Copy link
Collaborator Author

@anish-n just a kind reminder

@nazariig
Copy link
Collaborator Author

@anish-n just a kind reminder

tests/pbh_test.py Show resolved Hide resolved
tests/pbh_test.py Show resolved Hide resolved
@nazariig
Copy link
Collaborator Author

@kktheballer please review & approve

@liat-grozovik liat-grozovik changed the title [pbh]: Implement Edit Flows [PBH] Implement Edit Flows Mar 30, 2022
@liat-grozovik liat-grozovik merged commit c752457 into sonic-net:master Mar 30, 2022
judyjoseph pushed a commit that referenced this pull request Apr 4, 2022
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects.
PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing.

HLD: sonic-net/SONiC#909

- What I did
Implemented Edit Flows in scope of PBH enhancement

- How I did it
Implementation is done according to the PBH HLD

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Apr 4, 2022
In order to include the following commit:
c752457 [PBH] Implement Edit Flows (sonic-net/sonic-utilities#2093)

sonic-utilities
f70dc27 [techsupport] Handle minor fixes of TS Lock and update auto-TS (#2114)
51d3550 Fix issues in clear_qos (#2122)
6d3aa1e [GCU] Optimizing moves by adding generators for keys/tables (#2120)
65a5a6b Fixing get port speed when oper status is down (#2123)
c752457 [PBH] Implement Edit Flows (#2093)
827358f [debug dump] dump interface module added (#2070)

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants