-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy Based Hashing: Edit Flows HLD #909
Merged
liat-grozovik
merged 2 commits into
sonic-net:master
from
nazariig:master-pbh-edit-flows
Jan 15, 2022
Merged
Policy Based Hashing: Edit Flows HLD #909
liat-grozovik
merged 2 commits into
sonic-net:master
from
nazariig:master-pbh-edit-flows
Jan 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@anish-n could you please review and provide your feedback? |
@anish-n please have a look |
@anish-n just a kind reminder |
anish-n
reviewed
Jan 11, 2022
anish-n
approved these changes
Jan 14, 2022
liat-grozovik
approved these changes
Jan 15, 2022
This was referenced Mar 30, 2022
liat-grozovik
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Mar 30, 2022
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. PBH OA interprets series of Redis HSET/HDEL as SONiC SET operation and internally does the diff of existing/supplied configuration to deploy the new changes. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - Why I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
liat-grozovik
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Mar 30, 2022
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - How I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
judyjoseph
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Apr 4, 2022
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - How I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
judyjoseph
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Apr 4, 2022
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. PBH OA interprets series of Redis HSET/HDEL as SONiC SET operation and internally does the diff of existing/supplied configuration to deploy the new changes. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - Why I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. PBH OA interprets series of Redis HSET/HDEL as SONiC SET operation and internally does the diff of existing/supplied configuration to deploy the new changes. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - Why I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
PBH Edit Flows is a second phase of PBH feature implementation. It allows user to modify the already existing objects. PBH Edit Flows offer a full entity update which assumes Config DB field ADD/UPDATE/REMOVE processing. HLD: sonic-net/SONiC#909 - What I did Implemented Edit Flows in scope of PBH enhancement - How I did it Implementation is done according to the PBH HLD Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com