Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Documents #652

Merged
merged 14 commits into from
Oct 6, 2022
Merged

Refactor Documents #652

merged 14 commits into from
Oct 6, 2022

Conversation

mcjcloud
Copy link

@mcjcloud mcjcloud commented Sep 28, 2022

Refactors documents to be more concise.

Changes

  • Finally rename "object" to "document"
  • Remove unused models related to "object"
  • Consolidate API used by Go versus Flutter by removing outdated functions

Closes #624

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@mcjcloud mcjcloud marked this pull request as draft September 28, 2022 21:01
@ntindle ntindle mentioned this pull request Oct 3, 2022
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Base: 5.41% // Head: 5.42% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ab3f0b0) compared to base (e6a3b43).
Patch coverage: 76.47% of modified lines in pull request are covered.

❗ Current head ab3f0b0 differs from pull request most recent head c75bfed. Consider uploading reports for the commit c75bfed to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           staging-0.6.0    #652   +/-   ##
=============================================
  Coverage           5.41%   5.42%           
=============================================
  Files                151     151           
  Lines              27747   27745    -2     
=============================================
+ Hits                1502    1504    +2     
+ Misses             26106   26101    -5     
- Partials             139     140    +1     
Impacted Files Coverage Δ
pkg/client/client.go 32.43% <ø> (+5.15%) ⬆️
pkg/motor/motor.go 26.41% <76.47%> (+2.38%) ⬆️
pkg/client/account.go 62.50% <0.00%> (-9.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcjcloud mcjcloud marked this pull request as ready for review October 5, 2022 21:49
@mcjcloud mcjcloud changed the title [WIP] start refactor documents Refactor Documents Oct 5, 2022
pkg/motor/query.go Show resolved Hide resolved
internal/document/util.go Outdated Show resolved Hide resolved
internal/document/util.go Outdated Show resolved Hide resolved
internal/document/util.go Outdated Show resolved Hide resolved
pkg/logger/logger.go Outdated Show resolved Hide resolved
pkg/motor/motor.go Outdated Show resolved Hide resolved
pkg/motor/motor.go Outdated Show resolved Hide resolved
pkg/motor/motor.go Outdated Show resolved Hide resolved
pkg/motor/motor.go Outdated Show resolved Hide resolved
proto/motor/v1/request.proto Outdated Show resolved Hide resolved
internal/document/document_test.go Outdated Show resolved Hide resolved
internal/document/interaction.go Outdated Show resolved Hide resolved
@mcjcloud mcjcloud merged commit 623770d into staging-0.6.0 Oct 6, 2022
@prnk28 prnk28 linked an issue Oct 7, 2022 that may be closed by this pull request
3 tasks
@prnk28 prnk28 deleted the ref_documents branch August 7, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor SchemaDocument
4 participants