Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/schema service in who is #653

Closed
wants to merge 6 commits into from
Closed

Conversation

joshLong145
Copy link

@joshLong145 joshLong145 commented Sep 29, 2022

  • addition of service endpoint in WhoIs DIDDocument to register a WhatIs did as a service.

Changes

  • Item 1
  • Item 2

API Updates

New Features (required)

Deprecations (required)

Enhancements (optional)

Checklist

  • Unit tests
  • Documentation

References (optional)

Fixes
Connects

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Base: 5.39% // Head: 5.05% // Decreases project coverage by -0.34% ⚠️

Coverage data is based on head (c1df07d) compared to base (17d341c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #653      +/-   ##
========================================
- Coverage   5.39%   5.05%   -0.35%     
========================================
  Files        151     131      -20     
  Lines      27772   26203    -1569     
========================================
- Hits        1499    1325     -174     
+ Misses     26133   24770    -1363     
+ Partials     140     108      -32     
Impacted Files Coverage Δ
x/schema/keeper/msg_server_schema.go 0.00% <0.00%> (ø)
internal/keyring/keyring.go 54.83% <0.00%> (-1.62%) ⬇️
pkg/motor/create_schema.go
pkg/crypto/mpc/wallet.go
pkg/crypto/mpc/cosekey.go
pkg/motor/create_bucket.go
pkg/motor/bucket_resolver.go
pkg/motor/login.go
pkg/motor/send_tokens.go
pkg/motor/alias.go
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcjcloud
Copy link

What does it mean to add a WhatIs as a service?

@ntindle
Copy link

ntindle commented Sep 30, 2022

What does it mean to add a WhatIs as a service?

+1

@joshLong145
Copy link
Author

This is a way of associating schemas with a whoIs instance. This allows the sdk to query schema with our explicit calls by the developer. For purposes of caching within the sdk for later queries

@ntindle
Copy link

ntindle commented Sep 30, 2022

This is a way of associating schemas with a whoIs instance. This allows the sdk to query schema with our explicit calls by the developer. For purposes of caching within the sdk for later queries

I’m sorry, this doesn’t make any sense to me. Can you give an example of the use?

@joshLong145
Copy link
Author

joshLong145 commented Sep 30, 2022

This is a way of associating schemas with a whoIs instance. This allows the sdk to query schema with our explicit calls by the developer. For purposes of caching within the sdk for later queries

I’m sorry, this doesn’t make any sense to me. Can you give an example of the use?

with these service endpoints for schemas, sdk implementations can now pre initialize content by querying for it whenever they choose, such that its is available before invoking an explicit query command. or to put it simply pre fetching content.

@joshLong145 joshLong145 marked this pull request as draft September 30, 2022 18:11
@joshLong145
Copy link
Author

converted to a draft as im seeing issues with accessing key value stores from the registry keeper from the schema module context. looking into it.

@mcjcloud
Copy link

Okay the rationale makes sense. Is this work being tracked?

@prnk28 prnk28 closed this Mar 31, 2023
@prnk28 prnk28 deleted the feat/schema-service-in-whoIs branch August 7, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants