Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Wallet Encryption Vulnerability, Fix BLOK-32 #713

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

mcjcloud
Copy link

@mcjcloud mcjcloud commented Oct 20, 2022

Replaces wallet signing of vault shards with encryption using PSK. The PSK works as a good encryption key because it

  1. is a symmetric key that can be used for encryption and decryption
  2. is always required to create an account/sign in
  3. is shared between all devices, so no need to keep track of multiple encryption keys

Changes

  • Replace shard signing with encryption
  • Add a new encryptionKey property to motorNodeImpl

Fixes #680

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@prnk28 prnk28 changed the title Resolve Wallet Encryption Vulnerability Resolve Wallet Encryption Vulnerability, Fix BLOK-32 Oct 20, 2022
@prnk28
Copy link
Contributor

prnk28 commented Oct 20, 2022

@mcjcloud Next time lets use the branch provided by linear brayden/blok-32

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Base: 5.46% // Head: 5.59% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (2bc937a) compared to base (6abf4b9).
Patch coverage: 53.84% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #713      +/-   ##
========================================
+ Coverage   5.46%   5.59%   +0.12%     
========================================
  Files        154     154              
  Lines      27979   27968      -11     
========================================
+ Hits        1530    1564      +34     
+ Misses     26294   26241      -53     
- Partials     155     163       +8     
Impacted Files Coverage Δ
pkg/crypto/mpc/wallet.go 13.08% <0.00%> (+0.65%) ⬆️
pkg/motor/login.go 0.00% <0.00%> (ø)
pkg/motor/motor.go 29.29% <ø> (+3.82%) ⬆️
pkg/motor/create_account.go 42.28% <70.00%> (+16.13%) ⬆️
pkg/motor/create_bucket.go 11.90% <0.00%> (+11.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcjcloud mcjcloud merged commit 88abfd8 into dev Oct 20, 2022
@prnk28 prnk28 deleted the fix_BLOK-32-encryption branch August 7, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VULNERABILITY: Backup shards are being signed and not encrypted, making vault insecure
5 participants