Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hendrik/eng 33 #768

Closed
wants to merge 2 commits into from
Closed

Hendrik/eng 33 #768

wants to merge 2 commits into from

Conversation

Oozyx
Copy link

@Oozyx Oozyx commented Nov 23, 2022 •
edited by ghost
Loading

Changes

  • Fix DID Document validator test cases
  • Added validation for verification method ID to not be a URL
  • Fix logic error with verification method validation (fail if controller IS empty string)

Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@linear
Copy link

linear bot commented Nov 23, 2022

ENG-33

@Oozyx Oozyx marked this pull request as ready for review November 23, 2022 21:59
@Oozyx Oozyx requested a review from prnk28 November 23, 2022 21:59
@prnk28 prnk28 closed this Mar 31, 2023
@prnk28 prnk28 deleted the hendrik/eng-33 branch August 7, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prnk28 prnk28 Awaiting requested review from prnk28

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oozyx @prnk28