Revert "feat: fix package structure with did modules" #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 102f276. feat: fix package structure with did modules Remove/pkg cli deps (#815) * feat: remove cli pkgs * Revert "feat: remove cli pkgs" This reverts commit 858057e. * feat: swagger docs * feat: update lints --------- Signed-off-by: Prad Nukala <prad@sonr.io> fix: goreleaser status Revert "Remove/pkg cli deps (#815)" This reverts commit 43c28f8.
![senior-dev-bot[bot]](https://avatars.githubusercontent.com/in/282840?s=60&v=4){kind=small}
.goreleaser.yaml
Outdated
Comment on lines
172
to
178
|
|
||
| name_template: "Sonr - v{{.Version}} 🆔" | ||
| mode: replace | ||
| draft: true | ||
| draft: false | ||
| extra_files: | ||
| - glob: ./scripts/install.sh | ||
|
|
There was a problem hiding this comment.
The code changes look good. However, I do have a suggestion to improve the readability of the name_template value. Instead of using a string concatenation, you can use the fmt package to format the string with placeholders and pass the Version value when needed. This will make it easier to understand the logic and make any future modifications.
name_template: fmt.Sprintf("Sonr - v%d 🆔", .Version)Signed-off-by: Prad Nukala <prad@sonr.io>
PR Summary
|
Apply Sweep Rules to your PR?
|
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 102f276.
feat: fix package structure with did modules
Remove/pkg cli deps (#815)
This reverts commit 858057e.
Signed-off-by: Prad Nukala prad@sonr.io
fix: goreleaser status
Revert "Remove/pkg cli deps (#815)"
This reverts commit 43c28f8.