Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move anyhow integration behind a feature flag #4

Closed
sonro opened this issue Sep 28, 2022 · 2 comments
Closed

Move anyhow integration behind a feature flag #4

sonro opened this issue Sep 28, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@sonro
Copy link
Owner

sonro commented Sep 28, 2022

BREAKING CHANGE

Hide Error::downcast and Error::from_anyhow behind an "anyhow" feature flag. These are currently the only public APIs using anyhow types. Moreover only publicly re-export anyhow crate behind the feature flag.

This allows the default API to keep the implementation separate from the user and the "anyhow" feature-set to allow conversion between the two types.

@sonro sonro added the enhancement New feature or request label Sep 28, 2022
@sonro sonro added this to the v.0.2.0 milestone Sep 28, 2022
@sonro
Copy link
Owner Author

sonro commented Sep 28, 2022

ExitCode implmentation for anyhow::Error should only be public behind the flag.

@sonro
Copy link
Owner Author

sonro commented Sep 29, 2022

Due to the way the error_from macro invokes anyhow's macros, anyhow must remain public. Therefore we will not use a feature flag to gate off the anyhow integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant