Fix: normals default sigma is 0

sonsongithub · Apr 28, 2017 · 2c06a4a · 2c06a4a
1 parent d452190
commit 2c06a4a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/Sources/numsw/Matrix/MatrixRandom.swift b/Sources/numsw/Matrix/MatrixRandom.swift
@@ -14,7 +14,7 @@ extension Matrix where T: FloatingPointFunctions & FloatingPoint {
 
 extension Matrix where T: FloatingPoint & FloatingPointFunctions & Arithmetic {
 
-    public static func normal(mu: T = 0, sigma: T = 0, rows: Int, columns: Int) -> Matrix<T> {
+    public static func normal(mu: T = 0, sigma: T = 1, rows: Int, columns: Int) -> Matrix<T> {
         // Box-Muller's method
         let u1 = uniform(low: T(0), high: T(1), rows: rows, columns: columns)
         let u2 = uniform(low: T(0), high: T(1), rows: rows, columns: columns)

diff --git a/Sources/numsw/NDArray/NDArrayRandom.swift b/Sources/numsw/NDArray/NDArrayRandom.swift
@@ -10,7 +10,7 @@ extension NDArray where T: FloatingPointFunctions & FloatingPoint {
 
 extension NDArray where T: FloatingPoint & FloatingPointFunctions & Arithmetic {
 
-    public static func normal(mu: T = 0, sigma: T = 0, shape: [Int]) -> NDArray<T> {
+    public static func normal(mu: T = 0, sigma: T = 1, shape: [Int]) -> NDArray<T> {
         let u1 = uniform(low: T(0), high: T(1), shape: shape)
         let u2 = uniform(low: T(0), high: T(1), shape: shape)
 

diff --git a/Tests/numswTests/NDArrayTests/NDArrayRandomTests.swift b/Tests/numswTests/NDArrayTests/NDArrayRandomTests.swift
@@ -10,6 +10,11 @@ class NDArrayRandomTests: XCTestCase {
         }
     }
 
+    func testNormal() {
+        let a = NDArray<Double>.normal(mu: 0, sigma: 1, shape: [1000])
+        print(a.elements)
+    }
+
     static var allTests: [(String, (NDArrayRandomTests) -> () throws -> Void)] {
         return [
             ("testUniform", testUniform)