Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔮 ldoc-custom binary origin #1

Closed
metaory opened this issue Jul 16, 2024 · 7 comments
Closed

🔮 ldoc-custom binary origin #1

metaory opened this issue Jul 16, 2024 · 7 comments

Comments

@metaory
Copy link

metaory commented Jul 16, 2024

I don't see the source for this binary
ldoc-custom

How did this came to be?

What is it exactly?!

@sontungexpt
Copy link
Owner

This is the origin of those scripts. My bad, open source should show everything. It's just an 'ldoc' wrapper with some scripts that help you replace the CSS file and add a little JS to the HTML file to fix 'the a tag with name properties not working already'. I really don't know why??

@metaory
Copy link
Author

metaory commented Jul 17, 2024

This is the origin of those scripts. My bad, open source should show everything. It's just an 'ldoc' wrapper with some scripts that help you replace the CSS file and add a little JS to the HTML file to fix 'the a tag with name properties not working already'.

Great, thanks for your prompt reply, yes I'm sure you can imagine how bad it looks to put a binary with no indication of how it was built, I suggest to include in the same repo to avoid confusions? I'm sure I wasn't the only one who saw this and avoided your solution, I'm just the first who report it.

Thanks again 🙏

@metaory
Copy link
Author

metaory commented Jul 17, 2024

https://github.com/sontungexpt/stilux-dotfiles/blob/v5-new/scripts%2Fstilux%2Fusers%2Frecord

umm I still cant figure how this produced a binary..

for a wrapper as you describe I expected something like this;

#!/bin/bash

echo doing_stuff_stuff
echo more_stuff..

ldoc $@

wont be a binary,

am I missing something?

@sontungexpt
Copy link
Owner

https://github.com/sontungexpt/stilux-dotfiles/blob/v5-new/scripts%2Fstilux%2Fusers%2Frecord

umm I still cant figure how this produced a binary..

for a wrapper as you describe I expected something like this;

#!/bin/bash

echo doing_stuff_stuff
echo more_stuff..

ldoc $@

wont be a binary,

am I missing something?

ah sorry, This is the origin
https://github.com/sontungexpt/stilux-dotfiles/blob/v5-new/scripts/stilux/users/ldoc-custom
I used phone to answer you so i had mistake

@metaory
Copy link
Author

metaory commented Jul 17, 2024

https://github.com/sontungexpt/stilux-dotfiles/blob/v5-new/scripts%2Fstilux%2Fusers%2Frecord

umm I still cant figure how this produced a binary..
for a wrapper as you describe I expected something like this;

#!/bin/bash

echo doing_stuff_stuff
echo more_stuff..

ldoc $@

wont be a binary,
am I missing something?

ah sorry, This is the origin https://github.com/sontungexpt/stilux-dotfiles/blob/v5-new/scripts/stilux/users/ldoc-custom I used phone to answer you so i had mistake

no worries, thanks, but that still wont be a binary right?

$ file ldoc-custom

ldoc-custom: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=d13794c3e9e3393d0508bf4be6ef846e780a7185, for GNU/Linux 4.4.0, stripped

the file you linked is;

$ file scripts/stilux/users/ldoc-custom

scripts/stilux/users/ldoc-custom: Bourne-Again shell script, Unicode text, UTF-8 text executable

@sontungexpt
Copy link
Owner

I updated ldoc-custom new. May be this is not good. I wrote it quite a while ago.

@metaory
Copy link
Author

metaory commented Jul 17, 2024

I updated ldoc-custom new. May be this is not good. I wrote it quite a while ago.

I see you replaced the binary on 6290da2

Now I cant stop wondering what it was all the while before your commit! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants