Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git.io is closed #102

Closed
dgw opened this issue Jan 14, 2022 · 1 comment · Fixed by #106
Closed

git.io is closed #102

dgw opened this issue Jan 14, 2022 · 1 comment · Fixed by #106
Assignees
Labels
Milestone

Comments

@dgw
Copy link
Member

dgw commented Jan 14, 2022

GitHub shut down new links at git.io this week with no advance warning. This plugin has been using the service to shorten the URLs in webhook events:

res = requests.post('https://git.io', {'url': url})

We need an alternative, and I'm sad to say the only viable options might be TinyURL or Bitly. Those are the only URL shorteners I can think of that have lasted longer than git.io's 10 years.

Fortunately nothing is broken, since this plugin also gracefully handles failure to shorten links. Sending the POST request is now a waste of time (because it is guaranteed to be rejected with an error), but webhooks and such will still be sent to IRC with the original URL.

@dgw dgw added the tweak label Jan 14, 2022
This was referenced Jan 19, 2022
@dgw
Copy link
Member Author

dgw commented May 2, 2022

Having had a few months to think about this, I'm still not inclined to switch this plugin over to TinyURL or Bitly. Best solution for now is going to be removing the link-shortener function in a maintenance release.

The feature can always be restored if a decent alternative comes to light.

@dgw dgw added this to the 0.4.6 milestone May 2, 2022
@dgw dgw self-assigned this May 2, 2022
@dgw dgw closed this as completed in #106 May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant