Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on unicode but only with my Nick (SystemDisc) #38

Closed
SystemDisc opened this issue Mar 21, 2012 · 6 comments
Closed

Crashes on unicode but only with my Nick (SystemDisc) #38

SystemDisc opened this issue Mar 21, 2012 · 6 comments
Labels
Bug Things to squish; generally used for issues High Priority

Comments

@SystemDisc
Copy link

first found bug when entering string: "I call my ex-girlfriend's father isä"

[Mar 21 13:46:34] <SystemDisc> I call my ex-girlfriend's father isä
[Mar 21 13:46:34] * Willie has quit (Client exited)
[Mar 21 13:48:22] <SystemDisc> test: ä
[Mar 21 13:48:23] * Willie has quit (Client exited)
[Mar 21 13:50:25] <SystemDisc> ö
[Mar 21 13:50:26] * Willie has quit (Client exited)
[Mar 21 13:56:21] <SystemDisc> ö
[Mar 21 13:56:21] * Willie has quit (Client exited)

Doesn't affect Willie when entered by other Nicks
[Mar 21 13:49:37] <elad> Ü
[Mar 21 13:49:39] <elad> Nope
[Mar 21 13:49:47] <elad> Is it just ä?
[Mar 21 13:49:59] <cathy> ö
[Mar 21 13:50:00] <cathy> å

[Mar 21 13:51:06] <elad> Bugman
[Mar 21 13:51:11] <cathy> :D:D:D:D:D:D lol elad
[Mar 21 13:51:26] <elad> XD
[Mar 21 13:51:29] <cathy> willie you're being ridiculous
[Mar 21 13:51:54] <elad> à
[Mar 21 13:52:02] <cathy> ë
[Mar 21 13:52:02] <elad> Á
[Mar 21 13:52:05] <cathy> ï
[Mar 21 13:52:09] <cathy> ü
[Mar 21 13:52:13] <elad> Ú
[Mar 21 13:52:22] <cathy> I can't make cedilles
[Mar 21 13:52:23] <elad> A
[Mar 21 13:52:27] <cathy> or don't know how to
[Mar 21 13:52:41] <elad> Ipad keyboard makes it easier for me
[Mar 21 13:52:44] <cathy> ç
[Mar 21 13:52:49] <cathy> there
[Mar 21 13:52:52] <elad> c
[Mar 21 13:53:01] <cathy> Ç
[Mar 21 13:53:02] <falory> ? eee this is fun
[Mar 21 13:53:05] <cathy> â
[Mar 21 13:53:06] <cathy> ê
[Mar 21 13:53:08] <falory> Not sure what we're doing but it looks fun!
[Mar 21 13:53:09] <cathy> î
[Mar 21 13:53:11] <cathy> :D:D:D:D
[Mar 21 13:53:15] <falory> ?huh. wonder what that is.
[Mar 21 13:53:22] <cathy> testing which characters Willie doesn't like
[Mar 21 13:53:28] <falory> o0o
[Mar 21 13:53:35] * falory throws a ? at Willie
[Mar 21 13:53:38] <elad> Willie hates ä
[Mar 21 13:53:39] <cathy> :D
[Mar 21 13:53:41] <cathy> ö
[Mar 21 13:53:51] <elad> ä
[Mar 21 13:54:01] <Joshua> ä
[Mar 21 13:54:02] <falory> ? ? ? ?
[Mar 21 13:54:04] <elad> Now he doesn't crash
[Mar 21 13:54:05] <falory> o0o pretty!
[Mar 21 13:54:06] <cathy> äöäöäöäöäöä
[Mar 21 13:54:14] <elad> Might have been a coincidence
[Mar 21 13:54:16] <falory> ? I really like the butterfly looking character.

@heigren
Copy link

heigren commented Mar 21, 2012

btw

CTCP VERSION reply from SystemDisc: XChat-WDK 1503 [x64] / Windows 7 [2.99GHz]
Characterset: IRC (Latin/Unicode Hybrid)

@SystemDisc
Copy link
Author

Error was caused by my Character encoding: Latin-1/UTF-8 hybrid
I'm keeping it open because it's exploitable

@tyrope
Copy link

tyrope commented Mar 22, 2012

Tagging original creator of program for awareness @myano

@embolalia
Copy link
Contributor

After quit, it rejoins, and the PID stays the same. So it's quitting, but the process isn't terminating. Interesting...

@embolalia
Copy link
Contributor

Fixed upstream, merged with 349b1e9

Closing.

@myano
Copy link
Contributor

myano commented Mar 27, 2012

Totally didn't see this. I apologize.

Yea I had found this issue when someone pasted just an ISO-8559-1 character and UTF complained, but yea I really should add a few more encodings, because if someone messages something that isn't UTF-8 nor ISO-8559-1 jenni may crash. Though I haven't seen this replicated yet. ( I had someone try it but jenni survived)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Things to squish; generally used for issues High Priority
Projects
None yet
Development

No branches or pull requests

5 participants