Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech]: Add mechanism for external regulation for assets operations #1014

Closed
2 tasks
vovac12 opened this issue Apr 26, 2024 · 2 comments · Fixed by #1043
Closed
2 tasks

[Tech]: Add mechanism for external regulation for assets operations #1014

vovac12 opened this issue Apr 26, 2024 · 2 comments · Fixed by #1043
Assignees
Labels
tech Technical task

Comments

@vovac12
Copy link
Contributor

vovac12 commented Apr 26, 2024

Problem statement

We want to support regulated assets

Description

Currently we work with permissions pallet directly, but to make assets regulation for extensible we should move all checks to Config trait associated type

Definition of Done

  • Add trait for assets operations regulation
  • Move permissions pallet logic used in assets pallet to this trait

Requirements

  • New trait should be implemented for tuples like (A, B)
  • New trait should contain method for each assets operation like mint, burn, transfer, etc.
@vovac12 vovac12 added the tech Technical task label Apr 26, 2024
@vovac12 vovac12 added this to the DeFi-R milestone Apr 26, 2024
@HaidarJbeily7 HaidarJbeily7 self-assigned this May 8, 2024
@HaidarJbeily7 HaidarJbeily7 reopened this May 23, 2024
@Trezeguet1
Copy link

The task is merged, but it does not change the logic in any way, it is a task for preparing interfaces for the implementation of defi-r

We are waiting for this PR to be merged so that new extrinsics that are needed for the test can be added
#1044

The current logic is implemented this way on the QA side:

Pallet: assets

Methods are : mint, transfer, burn, register, update_own_balance

Purpose: the testcase should be contained in the frame of just checking that after we extract permission logic in the assets to external trait, we had all assets operation working just the same as before

The asset ID needs to be written in this format, etc:
0x020000000000000000000000000000000000000000000000000000000000000000
And for amount: 100000000000000000000

Such an extrinsik should call from a sudo account with root rights

telegram-cloud-photo-size-2-5371086999034913087-y

@Trezeguet1
Copy link

Testing of the task is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech Technical task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants