Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode support in value fetching. #61

Closed
ferd opened this issue Nov 10, 2021 · 1 comment · Fixed by #62
Closed

Unicode support in value fetching. #61

ferd opened this issue Nov 10, 2021 · 1 comment · Fixed by #62

Comments

@ferd
Copy link

ferd commented Nov 10, 2021

See erlang/rebar3#2644

The issue is located within https://github.com/soranoba/bbmustache, specifically at

Value = iolist_to_binary(ValueSerializer(get_data_recursive(Keys, Data, <<>>, State))),
, where the code should likely call for unicode:characters_to_binary instead of iolist_to_binary.

There are likely other locations for such calls, but sending in unicode data that has a wide representation can break when the codepoints get too large with the current calls.

@soranoba
Copy link
Owner

I'm checking the correction within the scope of the test.
If you need to take other measures, please create a new issue.

Thanks for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants