Fixing possible issue with basic engine #1059
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving the check inside the CTE changes the query plan so that it's no longer able to do an index only scan. That would have a significant impact on fetch performance in all cases. That's not desirable for this edge case, which is obnoxious and crops up infrequently in some systems some of the time, but I've never been able to reproduce it. The Lifeline plugin only rescues If this situation is ongoing, or you can reproduce it and we can try to diagnose together, please open an issue for investigation. |
sorentwo
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all, thank you for a great software.
We encountered a bug, when we have 10+ jobs have their
attempts1 with amax_attemptsalso equals to 1.We double checked a lifeline plugin, but this jobs was forever stuck in
availablewith 1 attempt and 1 max_attempt.Due to current way how jobs retrieved in Engine there is a possibility, that some queue can be stuck forever.
There is a possible fix for this (i will try to investigate why do we have a problem with Lifeline)