Treat returned error tuples as a job failure #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sorentwo the diff here looks awesome, thanks a lot! Tomorrow I can try out this on our app to test it out quickly and see how it does on practice |
|
@lucasmazza did you get a chance to test this out? I would like to include it in v0.5.0, which I’m hoping to release this week. |
|
I haven't deployed this to our staging server yet. I'll try to get back to
you tomorrow with this.
…On Tue, Jun 25, 2019, 18:26 Parker Selbert ***@***.***> wrote:
@lucasmazza <https://github.com/lucasmazza> did you get a chance to test
this out? I would like to include it in v0.5.0, which I’m hoping to release
this week.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAATYUSKOTVKNXEUQNJOCL3P4KERPANCNFSM4HZTNLXQ>
.
|
This changes `safe_call` to treat error tuples as a failure. The job will be retried just as if there was an exception or an exit, but the telemetry kind is different. Now telemetry events differentiate between a manual error and an exception. Closes #17
sorentwo
force-pushed
the
feature/error-tuples
branch
from
971a353
to
71e1fdb
Compare
|
@lucasmazza This looks good on my end. Getting it in for a 0.5 release. |
|
@sorentwo 👍 seems to be working fine here too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
safe_callto treat error tuples as a failure. The job will be retried just as if there was an exception or an exit, but the telemetry kind is different. Now telemetry events differentiate between a manual error and an exception.Closes #17
@lucasmazza Would you mind taking a look at this?