Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar projects overflow breaks the layout #453

Closed
5 tasks done
agoldis opened this issue Sep 21, 2021 · 3 comments · Fixed by #454
Closed
5 tasks done

Sidebar projects overflow breaks the layout #453

agoldis opened this issue Sep 21, 2021 · 3 comments · Fixed by #454

Comments

@agoldis
Copy link
Collaborator

agoldis commented Sep 21, 2021

Please note - issues that are not following the template will be closes automatically:

  • I have verified that all sorry-cypress services are running and accessible
  • I have read documentation and found no answer to my problem
  • I have searched issues / discussions and found to answer to my problem
  • I have read Minio Configutation guide - for issues related to Screenshots / Videos uploads for Minio
  • I have activated the debug mode DEBUG=cypress:server:api cy2 .... and have the network error

Summary

Sidebar overflow breaks the layout. See https://sorry-cypress-demo.herokuapp.com/

How to reproduce

Visible on https://sorry-cypress-demo.herokuapp.com/

Relevant logs / screenshots

n/a

Environment

  • sorry-cypress version: 2.0.0-beta.12
@agoldis
Copy link
Collaborator Author

agoldis commented Sep 21, 2021

@ImanMahmoudinasab Any chance you can take a look?

@agoldis
Copy link
Collaborator Author

agoldis commented Sep 21, 2021

@ImanMahmoudinasab nvm, fixed in #454

I've had a chance to work with the code you've recently contributed

  • thanks a lot for investing your time - very nice effort with a lot of attention to details! 🎉👍🏻
  • I would suggest to focus on letting other to contribute easily - e.g. custom margins and padding are quite hard to match for future contributors, whenever we can use default styling without overrides - let's do that!

agoldis added a commit that referenced this issue Sep 21, 2021
agoldis added a commit that referenced this issue Sep 21, 2021
@ImanMahmoudinasab
Copy link
Contributor

Sidebar overflow breaks the layout.

Oops! I missed it.

  • thanks a lot for investing your time - very nice effort with a lot of attention to details! 🎉👍🏻

Thank you @agoldis . It was my pleasure! 🙏🏻

  • I would suggest to focus on letting other to contribute easily - e.g. custom margins and padding are quite hard to match for future contributors, whenever we can use default styling without overrides - let's do that!

Sure! That was my first round with focus on functionality and not the structure and maintainablity. I would refactor them but first we should talk about the structure that I have in my mind and then apply it to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants