Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use grid to prevent items overflow #454

Merged
merged 1 commit into from Sep 21, 2021
Merged

fix: use grid to prevent items overflow #454

merged 1 commit into from Sep 21, 2021

Conversation

agoldis
Copy link
Collaborator

@agoldis agoldis commented Sep 21, 2021 •
edited

Closes #453

Kapture 2021-09-21 at 11 28 08

@agoldis agoldis mentioned this pull request Sep 21, 2021
Closed
5 tasks
@agoldis
Copy link
Collaborator Author

agoldis commented Sep 21, 2021

@ImanMahmoudinasab would appreciate your comments

@ImanMahmoudinasab
Copy link
Contributor

would appreciate your comments

Looks fine to me. However, in the future, I would break the codes into more granular components to make them easy to change and maintain. For the first round, I think using sx and style for styling is ok.

@agoldis agoldis merged commit f57fa39 into master Sep 21, 2021
@agoldis agoldis deleted the feat/fix-sidebar-overflow branch September 21, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar projects overflow breaks the layout
2 participants
@agoldis @ImanMahmoudinasab