Fix base64 padding with multiple =-signs. An equal amount of dots is … #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…required in output instead of merging all =-signs into one dot, which can then not be decoded. Test string: SELECT * from version where "isHelper" order by "order" desc will be encode to U0VMRUNUICogZnJvbSB2ZXJzaW9uICB3aGVyZSAiaXNIZWxwZXIiIG9yZGVyIGJ5ICJvcmRlciIgZGVzYw. missing a dot at the end making it undecodable. Since =-signs only appear at the end anyway, we don't need the explicit '$' in the regexp
|
I'll look into this. Base64 was not really a good choice so it'll be replaced with something more robust in near future. |
|
Maybe; but the currently implementation is broken and my commit fixes it. |
|
Im more that happy to merge this PR, could you please include a few example queries that did not work for you. I tried the query you provided and it went through just fine (no issues with decoding). |
|
It seems a Providing additional queries is difficult as I cannot predict when multiple padding-chars are added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…required in output
instead of merging all =-signs into one dot, which can then not be decoded. Test string:
SELECT * from version where "isHelper" order by "order" desc;will be encode to
U0VMRUNUICogZnJvbSB2ZXJzaW9uICB3aGVyZSAiaXNIZWxwZXIiIG9yZGVyIGJ5ICJvcmRlciIgZGVzYw.
missing a dot at the end making it undecodable.
Since =-signs only appear at the end anyway, we don't need the explicit '$' in the regexp