-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Baseline, examples] Migrate to Flax (or other NN libraries) #1059
Comments
How important is Flax to the migration? I've been exploring pgx and it seems really nice and I've started using it, but my go to is equinox (https://github.com/patrick-kidger/equinox, probably the second most popular behind flax). I would be down to work on this issue, as long as you are ok with equinox instead of flax. |
Thank you for your interest in pgx! 🙏 Whether it's Flax or not isn't particularly important. I simply considered it as the first candidate because I thought it's the framework used by the largest community. I think Equinox is a good choice. The issue I had with Haiku was that batch normalization couldn't handle dimensions that were made by If you could send a PR, I would greatly appreciate it. If you send a PR, I'll check the following points on my end and then merge:
I believe this will be a relatively significant change, so from a review standpoint, it would be preferable if the PR could focus on changes to the NN module and keep other changes to a minimum. |
At the very least, there will be no members in our team working on this issue by the end of the year, so it's fine for you to proceed at your own pace 👍 |
The text was updated successfully, but these errors were encountered: