Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS headers #1

Closed
lakshmi-kannan opened this issue Sep 13, 2019 · 3 comments
Closed

CORS headers #1

lakshmi-kannan opened this issue Sep 13, 2019 · 3 comments

Comments

@lakshmi-kannan
Copy link

Hi there!

Thanks for hosting the API to get SVGs. I am trying to make a request from my web app and browser complains about CORS headers. Any chance you can set Access-Control-Allow-Origin: * response header when we hit https://logos-api.funkreich.de/?q=vue.js?

Screenshot from 2019-09-13 17-08-24
@soulchild
Copy link
Owner

Hi Lakshmi,

to be honest, the Logos-API is not supposed to be used by third parties directly which is why I'm reluctant to just allow CORS access from anywhere. Its main purpose is to serve as a backend for my Sketch logo plugin.

May I suggest that you host the API yourself?

Thanks!

@lakshmi-kannan
Copy link
Author

@soulchild Thanks for your response! I'll host the API myself then.

@lakshmi-kannan
Copy link
Author

@soulchild and others - Here is a PR lakshmi-kannan#1 to show how I deployed this to AWS beanstalk. May help someone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soulchild @lakshmi-kannan