Permalink
Commits on Feb 16, 2016
  1. @arthurnn

    Merge pull request #135 from pra85/patch-1

    Fix a minor typo in Readme
    arthurnn committed Feb 16, 2016
Commits on Feb 13, 2016
  1. @pra85

    Fixes a minor typo in Readme

    Remove extra `a`
    pra85 committed Feb 13, 2016
Commits on Feb 1, 2016
  1. @arthurnn

    Merge pull request #133 from m1foley/cleanup-clarity

    Improve readability of cleanup method calls
    arthurnn committed Feb 1, 2016
  2. @arthurnn

    Merge pull request #129 from Shopify/test_for_detroying_single_row_wh…

    …en_the_id_is_not_1_sc_master
    
    Adding failing test and fix for potential data destruction
    arthurnn committed Feb 1, 2016
Commits on Jan 26, 2016
  1. @m1foley

    Improve readability of cleanup method calls

    `cleanup(:run)` is more self-explanatory than `cleanup(true)`.
    m1foley committed Jan 26, 2016
Commits on Nov 2, 2015
  1. @camilo
  2. @camilo
Commits on Sep 14, 2015
  1. @arthurnn

    Merge pull request #121 from sj26/dont-choke-on-long-trigger-names

    Truncate long trigger names
    arthurnn committed Sep 14, 2015
Commits on Sep 4, 2015
  1. @sj26

    Truncate long trigger names

    We are seeing:
    
        ==  SomeHorriblyLongMigrationInvolvingTablesWithNamesFarTooLongForHumanBeingsToConsiderReasonable: migrating
        I, [2015-07-15T12:07:08.972714 #47706]  INFO -- : Starting LHM run on table=lhmn_tables_with_names_far_too_long_for_human_beings_to_consider
        I, [2015-07-15T12:07:08.972868 #47706]  INFO -- : Starting run of class=Lhm::Migrator
        I, [2015-07-15T12:07:09.012700 #47706]  INFO -- : Starting run of class=Lhm::Entangler
        E, [2015-07-15T12:07:09.015775 #47706] ERROR -- : Error in class=Lhm::Entangler, reverting. exception=ActiveRecord::StatementInvalid message=Mysql2::Error: Identifier name 'lhmt_del_tables_with_names_far_too_long_for_human_beings_to_consider_reasonable' is too long: create trigger `lhmt_del_tables_with_names_far_too_long_for_human_beings_to_consider_reasonable`
        ...
    
    It looks like this has already been faced in the migrator:
    
        def archive_name
          "lhma_#{ startstamp }_#{ @origin.name }"[0...64]
        end
    
    So let's truncate here as well.
    sj26 committed Jul 15, 2015
Commits on Jul 15, 2015
  1. @arthurnn

    Merge pull request #118 from sj26/add-ar-and-mysql-as-development-gems

    Running tests requires active_record and mysql
    arthurnn committed Jul 15, 2015
Commits on Jul 6, 2015
  1. @sj26
Commits on May 19, 2015
  1. @bjk-soundcloud

    Merge pull request #114 from soundcloud/bjk/autoinc

    Update chunker requirements
    bjk-soundcloud committed May 19, 2015
Commits on May 18, 2015
  1. @bjk-soundcloud

    Update chunker requirements

    The chunker does not require an auto_increment column, it simply
    requires an integer column in order to find the start/limit of the
    table.
    
    Relax the migrator/table checks to only look for an `id` INT column.
    * Add support for BIGINT `id` columns
    * Add fixture for BIGINT `id` column
    * Add test for BIGINT `id` columns
    * Add fixture for "broken" varchar `id` column
    * Update specs
    * Update README with changes, and note about sparse `id` data
    bjk-soundcloud committed May 14, 2015
Commits on May 14, 2015
  1. @arthurnn

    Merge pull request #112 from christophermanning/patch-1

    Add license information to lhm.gemspec
    arthurnn committed May 14, 2015
  2. @christophermanning

    lhm.gemspec: set license to BSD-3-Clause

    'BSD-3-Clause' is less ambiguous than 'New BSD' and it's also the url slug used by the opensource.org URL http://opensource.org/licenses/BSD-3-Clause
    christophermanning committed May 14, 2015
Commits on May 12, 2015
  1. @christophermanning

    Add license information to lhm.gemspec

    Set the license to New BSD
    christophermanning committed May 12, 2015
Commits on May 11, 2015
  1. @arthurnn

    Merge pull request #110 from jasonhl/add_logging_for_throttler

    Adding logging for debugging slave lag
    arthurnn committed May 11, 2015
Commits on May 5, 2015
  1. @camilo
Commits on Apr 27, 2015
  1. @arthurnn
Commits on Apr 21, 2015
  1. @arthurnn

    Merge pull request #104 from soundcloud/inject_conn_slave_lag_throttler

    Inject connection into throttler
    arthurnn committed Apr 21, 2015
Commits on Apr 18, 2015
  1. @arthurnn

    Merge pull request #105 from arturo-c/master

    Lhm migrator failing if innodb and global timeouts are not set on db.
    arthurnn committed Apr 18, 2015
  2. @arturo-c
Commits on Apr 16, 2015
  1. @arthurnn

    Inject connection into throttler

    It is hard to access to connection globally. At the moment to setup a
    global throttler that depends on the connection we need to pass it a
    initialization time, which is not handy.
    We can instead inject the connection at the time we are running the throttler.
    arthurnn committed Apr 16, 2015
  2. @arthurnn
  3. @arthurnn

    Remove adapter method

    arthurnn committed Apr 16, 2015
Commits on Apr 15, 2015
  1. @arthurnn

    Fix build

    arthurnn committed Apr 15, 2015
Commits on Apr 14, 2015
  1. @arthurnn

    Test on ruby 2.2.x

    arthurnn committed Apr 14, 2015
Commits on Apr 8, 2015
  1. @arthurnn

    Prefer single quote strings

    arthurnn committed Apr 8, 2015
  2. @arthurnn

    Fix space styles

    arthurnn committed Apr 8, 2015
  3. @arthurnn

    Fix indentation

    arthurnn committed Apr 8, 2015
  4. @arthurnn
  5. @arthurnn
  6. @arthurnn

    Fix broken API

    arthurnn committed Apr 8, 2015
  7. @arthurnn
  8. @arthurnn

    Test on AR 2.3

    arthurnn committed Apr 8, 2015