Fix ASI issue with document.body fix #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souporserious
added a commit
that referenced
this pull request
Feb 16, 2016
Fix ASI issue with document.body fix
|
No worries, I appreciate your help on this. Tests would be awesome 😃 I have no experience with them yet, so that would help out a bunch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My fix in #7 unfortunately created an issue with automatic semicolon insertion here. The line I modified was interpreted as a function application to the preceding line. Explicitly declaring a variable fixes this issue.
Sorry for the trouble here. When this merges it would probably be a good idea to make a patch release. If I get some time I'm planning to write a basic test suite for this component, if that would be alright with you!