Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping js-slang #1827

Merged
merged 2 commits into from
Jun 26, 2021
Merged

bumping js-slang #1827

merged 2 commits into from
Jun 26, 2021

Conversation

martin-henz
Copy link
Member

@martin-henz martin-henz commented Jun 26, 2021

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@martin-henz martin-henz marked this pull request as draft June 26, 2021 00:02
@martin-henz martin-henz changed the title bumping js-slang DO NOT MERGE: bumping js-slang Jun 26, 2021
@martin-henz
Copy link
Member Author

This branch bumps js-slang to 0.5.4. The js-slang bump fixes #1825. But this branch has a failing test case, which seems to come from the infinite loop detector. I'll check with @JoeyChenSmart .

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 26, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 725bf65
Status: ✅  Deploy successful!
Preview URL: https://c446e33b.cadet-frontend.pages.dev

View logs

@coveralls
Copy link

Pull Request Test Coverage Report for Build 973487798

  • 10 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 30.011%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/utils/InfiniteLoopReporter.ts 10 11 90.91%
Totals Coverage Status
Change from base Build 970636237: -0.06%
Covered Lines: 3198
Relevant Lines: 9818

💛 - Coveralls

@martin-henz martin-henz changed the title DO NOT MERGE: bumping js-slang bumping js-slang Jun 26, 2021
@martin-henz martin-henz marked this pull request as ready for review June 26, 2021 05:21
@martin-henz martin-henz merged commit 45a9783 into master Jun 26, 2021
@jiayushe jiayushe deleted the 054 branch September 7, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants