-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SICP JS: Rework program snippets #1832
Merged
martin-henz
merged 5 commits into
source-academy:master
from
samuelfangjw:rework-code-snippets
Jun 27, 2021
Merged
SICP JS: Rework program snippets #1832
martin-henz
merged 5 commits into
source-academy:master
from
samuelfangjw:rework-code-snippets
Jun 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 974181707
💛 - Coveralls |
Pull Request Test Coverage Report for Build 975272159
💛 - Coveralls |
martin-henz
approved these changes
Jun 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine.
Pull Request Test Coverage Report for Build 975272159Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is dependent on source-academy/sicp#545.
In the image above, taken from the third program snippet in section 3.2.3, lines 2 to 15 are hidden. A user can click on the yellow button to reveal dependencies.
With this solution the only way to hide dependencies again is to close and reopen the snippet.
Type of change
How to test
Checklist