feat(authentication-service): add oauth-code read and write providers #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarpan-b
requested changes
Mar 31, 2021
|
|
||
| ### Providers | ||
|
|
||
| You can find documentation for some of the providers bindings this service provides [here](./src/providers/README.md) |
There was a problem hiding this comment.
You can find documentation for some of the providers available in this service [here]
| }); | ||
| response.redirect( | ||
| `${client.redirectUrl}?code=${token}&user=${this.user.username}`, | ||
| const token = await keycloackCodeWriter( |
There was a problem hiding this comment.
lets only keep one code writer provider. no need of separate for keycloak or google.
| @@ -9,112 +9,169 @@ A [provider](http://loopback.io/doc/en/lb4/Creating-components.html#providers) | |||
| is a class that provides a `value()` function. This function is called `Context` | |||
| when another entity requests a value to be injected. | |||
|
|
|||
| Here we create a provider for a logging function that can be used as a new | |||
| action in a custom [sequence](http://loopback.io/doc/en/lb4/Sequence.html). | |||
| ## Basic Usage | |||
There was a problem hiding this comment.
Mention that all these are optional.
|
Kudos, SonarCloud Quality Gate passed!
|
samarpan-b
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added providers to allow processing the code from Keycloak/Google authentications. Also removed username from subject of jwt tokens, and url of auth-redirects.
Type of change
Checklist: