Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(all-services): fix sonar code smells #1602

Merged
merged 1 commit into from
Aug 10, 2023
Merged

refactor(all-services): fix sonar code smells #1602

merged 1 commit into from
Aug 10, 2023

Conversation

shubhamp-sf
Copy link
Contributor

Description

This PR fixes all sonar code smells of Object.assign usage, and replaces it with spread operator where possible.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@shubhamp-sf shubhamp-sf force-pushed the fix/sonar-object-assign-smells branch 2 times, most recently from ae7246f to bd0283d Compare August 10, 2023 11:22
@shubhamp-sf
refactor(all-services): fix sonar code smells
e1223a0 
of `Object.assign` usage and replace with spread operator where possible
@shubhamp-sf shubhamp-sf force-pushed the fix/sonar-object-assign-smells branch from bd0283d to e1223a0 Compare August 10, 2023 12:12
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
18.0% 18.0% Duplication

@shubhamp-sf shubhamp-sf merged commit 51f1cc3 into master Aug 10, 2023
2 checks passed
@shubhamp-sf shubhamp-sf deleted the fix/sonar-object-assign-smells branch August 10, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shubhamp-sf