Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notification-service): add sequelize support in notification service #1784

Merged
merged 1 commit into from
Dec 6, 2023
Merged

feat(notification-service): add sequelize support in notification service #1784

merged 1 commit into from
Dec 6, 2023

Conversation

Surbhi-sharma1
Copy link
Contributor

@Surbhi-sharma1 Surbhi-sharma1 commented Oct 30, 2023 •
edited
Loading

add sequelize support in notification service

GH-1350

Description

Add sequelize support in notification service

Fixes #1350

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@Surbhi-sharma1 Surbhi-sharma1 requested a review from a team as a code owner October 30, 2023 06:54
@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as draft October 30, 2023 06:55
@Surbhi-sharma1 Surbhi-sharma1 changed the title feat(notification-service): add sequelize support in notification ser… feat(notification-service): add sequelize support in notification service Oct 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as ready for review December 4, 2023 12:28
@Surbhi-sharma1
feat(notification-service): add sequelize support in notification ser…
9351f52 
…vice

add sequelize support in notification service

GH-1350
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
32.0% 32.0% Duplication

@yeshamavani yeshamavani merged commit 7e381af into master Dec 6, 2023
5 checks passed
@yeshamavani yeshamavani deleted the GH-1350-3 branch December 6, 2023 12:50
@ajaypandey5 ajaypandey5 mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeshamavani yeshamavani yeshamavani requested changes

@samarpan-b samarpan-b samarpan-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to switch to Sequelize ORM in Services
3 participants
@Surbhi-sharma1 @samarpan-b @yeshamavani