Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification-service): fix for sending bulk notifications #88

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

mayank-SFIN571
Copy link
Contributor

bulk notification fix for accepting array and showing the same in swagger

Signed-off-by: mayank mayank.nauriyal@sourcefuse.com

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@mayank-SFIN571 mayank-SFIN571 changed the title notification-service fix for sending bulk notifications fix(notification-service): fix for sending bulk notifications Oct 30, 2020
…and showing the same in swagger

Signed-off-by: mayank <mayank.nauriyal@sourcefuse.com>
@samarpan-b samarpan-b merged commit 5d8ab0c into master Oct 30, 2020
@samarpan-b samarpan-b deleted the bulk-notif-fix branch October 30, 2020 19:01
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants