Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: Add scip-clang announcement #6229

Merged
merged 22 commits into from
May 15, 2023
Merged

blog: Add scip-clang announcement #6229

merged 22 commits into from
May 15, 2023

Conversation

varungandhi-src
Copy link
Contributor

No description provided.

Copy link
Contributor

@scalabilitysolved scalabilitysolved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good @varungandhi-src , I think we should celebrate more what it brings to the customer experience.

content/blogposts/2023/announcing-scip-clang.md Outdated Show resolved Hide resolved
content/blogposts/2023/announcing-scip-clang.md Outdated Show resolved Hide resolved
content/blogposts/2023/announcing-scip-clang.md Outdated Show resolved Hide resolved
content/blogposts/2023/announcing-scip-clang.md Outdated Show resolved Hide resolved
content/blogposts/2023/announcing-scip-clang.md Outdated Show resolved Hide resolved
content/blogposts/2023/announcing-scip-clang.md Outdated Show resolved Hide resolved
content/blogposts/2023/announcing-scip-clang.md Outdated Show resolved Hide resolved
content/blogposts/2023/announcing-scip-clang.md Outdated Show resolved Hide resolved
Copy link
Contributor

@scalabilitysolved scalabilitysolved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 🚀

Copy link
Contributor

@iskyOS iskyOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scalabilitysolved @varungandhi-src Just reviewed! I left some small suggestions to add line breaks, for some reason our website renders lists with poor spacing unless you add breaks at the end of them.

The post looks great to me for the persona of folks who are already indexing their C/C++ code and are deeply familiar with lsif-clang. For folks who aren't yet familiar, how would you feel about adding a section describing why this matters to them and what they'd gain if they were to start indexing their code?

Kind of like: "For teams with C/C++ code that are not yet indexing that code, indexing with scip-clang can provide significant upgrades..." etc.

That group may need some kind of guidance on how to get started with indexing too (maybe pointing to docs?) but I think that would go a long way to make sure they understand what this release means for them and where to go next.

content/blogposts/2023/announcing-scip-clang.md Outdated Show resolved Hide resolved
@varungandhi-src
Copy link
Contributor Author

@iskyOS

The post looks great to me for the persona of folks who are already indexing their C/C++ code and are deeply familiar with lsif-clang. For folks who aren't yet familiar, how would you feel about adding a section describing why this matters to them and what they'd gain if they were to start indexing their code?

Kind of like: "For teams with C/C++ code that are not yet indexing that code, indexing with scip-clang can provide significant upgrades..." etc.

I've added a paragraph + some bullet points for this. Can you take a second look?

That group may need some kind of guidance on how to get started with indexing too (maybe pointing to docs?) but I think that would go a long way to make sure they understand what this release means for them and where to go next.

I've linked to the scip-clang README twice, once at the beginning, and once under "try out scip-clang". The README contains adoption instructions. Do you think I need to highlight it differently or is that sufficient?

Copy link
Contributor

@scalabilitysolved scalabilitysolved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good.

@scalabilitysolved
Copy link
Contributor

The video demo is a nice touch @varungandhi-src, concise and shows the main features off.

Copy link
Contributor

@iskyOS iskyOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@varungandhi-src varungandhi-src merged commit aed4f1d into main May 15, 2023
@varungandhi-src varungandhi-src deleted the vg/scip-clang branch May 15, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants