Improvements on Recorder.

[chris-ramon]

Details

Related issue: #132

• Adds Recorder.Finish(...) method, such that a span will only be recorded to once (a recorder produces only one Store.Collect(...) call for a given SpanID).
• Updates httptrace client & server to call Recorder.Finish(...) in order to collect the span.
• Fixes recorder tests.

[slimsag]

add:

// Finish finishes recording and saves the recorded information to the
// underlying collector. If Finish is not called, then no data will be written
// to the underlying collector.

[bg451]

I'd vote for AggregateStore not being removed, since one of the nice things about Appdash is that it can be embedded in an application without many dependencies, ie influxdb in this case.

[chris-ramon]

I'd vote for AggregateStore not being removed, since one of the nice things about Appdash is that it can be embedded in an application without many dependencies, ie influxdb in this case.

Hi @bg451, thanks for giving ur thoughts about the AggregateStore being removed, would you mind continue the conversation about it in #127, this being is initial comment. This PR is just being build in top of it but it's main purpose is to improve the Recorder.

[slimsag]

LGTM

Let's def. move the AggregateStore conversation elsewhere.

EDIT: see #137