Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: VSCode Windows @-mention selector shows /, makes me type \ #2198

Closed
dominiccooney opened this issue Dec 8, 2023 · 0 comments · Fixed by #2215
Closed

bug: VSCode Windows @-mention selector shows /, makes me type \ #2198

dominiccooney opened this issue Dec 8, 2023 · 0 comments · Fixed by #2215
Assignees
@DanTup
Labels
bug Something isn't working clients/vscode

Comments

@dominiccooney
Copy link
Contributor

Version

Main a8d1fb3

Describe the bug

  1. Open a chat
  2. @-mention a file in a folder
  3. Type the path separator while entering the filename
Extension.Development.Host.CODE_OF_CONDUCT.md.-.lexical.-.Visual.Studio.Code.2023-12-08.12-12-56.mp4

Expected behavior

Expected behavior:

  • The autocomplete widget should use the platform path separator, \
  • I should be able to type \ or / as a path separator.

Actual behavior:

  • The autocomplete widget uses / as a path separator.
  • If I type / as a path separator, I get no files matching.

Additional context

It is tempting to just use / as the display and typing path separator, but this is annoying on Windows because "Copy Relative Path" will copy a path with \es in it.
@dominiccooney dominiccooney added bug Something isn't working clients/vscode labels Dec 8, 2023
@dominiccooney dominiccooney mentioned this issue Dec 8, 2023
Closed
DanTup added a commit that referenced this issue Dec 8, 2023
@DanTup
Handle context file searching using forward slashes on Windows
7527e3d 
See #2198
@DanTup DanTup mentioned this issue Dec 8, 2023
Merged
DanTup added a commit that referenced this issue Dec 10, 2023
@DanTup @dominiccooney
Handle context file searching using forward slashes on Windows (#2215)
59c4382 
Fixes #2198


## Test plan

- Run `pnpm test:e2e at-file` to run updated test, or:
- On Windows, open chat and try to attach a file in chat using
backslashes and forward slashes for searching filenames

---------

Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanTup DanTup

Labels
bug Something isn't working clients/vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle context file searching using forward slashes on Windows sourcegraph/cody
2 participants
@dominiccooney @DanTup