Handle context file searching using forward slashes on Windows #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dominiccooney another windows PR for ya :) |
|
I've opened #2241 too - not Windows specific, but depends on a function added in this PR to work. I'll rebase/merge that one after this lands (GitHub doesn't have a great way to do dependent PRs :-)) |
dominiccooney
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Beautiful.
Given your great comments I suggest we can simplify these conditionals to always replace / with the platform separator for a slight readability win.
If there were other Windows adaptations we were putting in those conditional blocks I would feel better about keeping the conditional blocks around.
Comment on lines
195
to
198
| if (path.sep === path.win32.sep) { | ||
| relativePath = relativePath.replaceAll(path.posix.sep, path.win32.sep) | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if (path.sep === path.win32.sep) { | |
| relativePath = relativePath.replaceAll(path.posix.sep, path.win32.sep) | |
| } | |
| relativePath = relativePath.replaceAll(path.posix.sep, path.sep) | |
Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
Co-authored-by: Dominic Cooney <dominic.cooney@sourcegraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2198
Test plan
pnpm test:e2e at-fileto run updated test, or: