Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody: VSCode history should list the current chat #339

Closed
toolmantim opened this issue May 29, 2023 · 9 comments · Fixed by sourcegraph/sourcegraph#52904
Closed

Cody: VSCode history should list the current chat #339

toolmantim opened this issue May 29, 2023 · 9 comments · Fixed by sourcegraph/sourcegraph#52904

Comments

@toolmantim
Copy link
Contributor

Now we have the [➕] button instead of clear conversation, we need to ensure the current conversation is also at the top of the conversation history list. Because at the moment, the [➕] button is more like a "Clear conversation" function vs the ChatGPT style list of conversations (where the current one is highlighted).

Steps to reproduce:

  1. Click history, and it's empty, but should list the current conversation
@toolmantim
Copy link
Contributor Author

Is this a tricky one to do @abeatrix?

@abeatrix
Copy link
Contributor

abeatrix commented May 30, 2023

@toolmantim Would this work as a temporary solution?
( a new button at the top as for the current convo and link it back to the current chat window`

Image

@toolmantim
Copy link
Contributor Author

Yesssss, that's pretty much it @abeatrix! 😍 And I can clean up the labelling.

@abeatrix
Copy link
Contributor

abeatrix commented May 31, 2023

@toolmantim Perfect! I've created a PR draft, feel free to play around with the labels in the PR and let me know if there are other things you would like me to change :)
sourcegraph/sourcegraph#52672

Update: no rush on this btw. I created a draft PR so you don't have to wait for me to get on 12 hours later, but if you can't get to this it's fine too!

@abeatrix
Copy link
Contributor

abeatrix commented Jun 2, 2023

Side notes, do you think we should use the first request from human as the description for each history item? I found using the last reply from Cody quite unhelpful sometime lol

image

@toolmantim
Copy link
Contributor Author

Yeah I found that too @abeatrix! Probably the last human request might be best?

An out there idea: could we ask Cody to come up with a good summary/title for the convo ala ChatGPT?

I'd love us to use friendly/relative dates too.

@abeatrix
Copy link
Contributor

abeatrix commented Jun 5, 2023

Update: Covered by sourcegraph/sourcegraph#52904

philipp-spiess referenced this issue in sourcegraph/sourcegraph Jun 12, 2023
This PR closes #52544,  #52848, #52889 and #52890.

The issues mostly overlapped, so I handled it in this PR.

Changes made:
1. Add history to the history list on each new conversation started.
2. Display the last human message in history instead of the assistant
message.
3. Add a delete button to delete individual chats from history.
4. Load the most recent chat, if available, from the history.
5. Fix the loading of context files.
6. Load the history messages to the end of the scroll position.

## Test plan

All E2E tests have passed.
https://www.loom.com/share/3dca98dd0db94c298df38ab79c5e72d1

---------

Co-authored-by: Philipp Spiess <hello@philippspiess.com>
ErikaRS referenced this issue in sourcegraph/sourcegraph Jun 22, 2023
This PR closes #52544,  #52848, #52889 and #52890.

The issues mostly overlapped, so I handled it in this PR.

Changes made:
1. Add history to the history list on each new conversation started.
2. Display the last human message in history instead of the assistant
message.
3. Add a delete button to delete individual chats from history.
4. Load the most recent chat, if available, from the history.
5. Fix the loading of context files.
6. Load the history messages to the end of the scroll position.

## Test plan

All E2E tests have passed.
https://www.loom.com/share/3dca98dd0db94c298df38ab79c5e72d1

---------

Co-authored-by: Philipp Spiess <hello@philippspiess.com>
@toolmantim
Copy link
Contributor Author

@deepak2431 I've noticed that sadly the chat history doesn't contain the current chat at the top still (like a list of conversations, current one included and highlighted). Was it intentional to leave it off, or has there been a regression?

@deepak2431
Copy link
Contributor

@toolmantim The current chat will be added to the history only after at least one conversation. I have implemented this behaviour so that it won't have a lot of blank items in the history chat. So, it was intentional to implement this way.

@toolmantim toolmantim reopened this Jul 21, 2023
@toolmantim toolmantim transferred this issue from sourcegraph/sourcegraph Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants