Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody: Button to return to current chat session from history #52672

Closed
wants to merge 1 commit into from

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented May 31, 2023

Close sourcegraph/cody#339

Added a new button on top that would go back to the current chat view:
image

Test plan

Passing the history e2e test

@sourcegraph-bot
Copy link
Contributor

📖 Storybook live preview

@toolmantim
Copy link
Contributor

Thank you @abeatrix!!

Unfortunately I don't think this quick approach will fix it after all… because we're going to get these situations (notice the same apparent history item switching between two chats):

Screen.Recording.2023-06-02.at.10.28.05.pm.mov

Is there a reason the current chat isn't added to the UserHistory list immediately when it is created? It seems like it's only added after an additional new chat is created.

If we can make sure the new chat immediately is added to the history, I think that would solve it, and bring it more in to line with our web implementation (and similar to other message interfaces ala iMessage, ChatGPT, WhatsApp, etc):

Screen.Recording.2023-06-02.at.10.21.14.pm.mov

@abeatrix
Copy link
Contributor Author

abeatrix commented Jun 2, 2023

Is there a reason the current chat isn't added to the UserHistory list immediately when it is created?

I'm not sure since I didn't implement this new design but I think it used to show up immediately in the old design. I can take a deeper look after Non-Stop Cody!

@toolmantim
Copy link
Contributor

(also spotted #52848 in the process of testing)

@abeatrix
Copy link
Contributor Author

abeatrix commented Jun 5, 2023

picked up by @deepak2431 in #52904

@abeatrix abeatrix closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cody: VSCode history should list the current chat
3 participants