Only search relative paths when @-mentioning files in chat #2241
Conversation
|
|
||
| // We should only match the relative visible path, not parts of the full path outside of the workspace. | ||
| // Eg. searching for "source" should not find all files if the project is inside `C:\Source`. | ||
| await chatInput.fill('@fixtures') // fixture is in the test project folder name, but in the relative paths. |
There was a problem hiding this comment.
Once #2235 lands, you can make this more robust by adding workspaceDirectory alongside page, sidebar and get the path to the workspace directory. That will let you assert that fixtures really is in that path and remains that way.
There was a problem hiding this comment.
Oh yeah, good point. I've added a TODO about that. If you're planning to land that soon I can wait and fix it up here, or if you think I should land this as-is and fix later, let me know.
I've rebased this on main after merging #2208 so I think this should all be green now.
DanTup
force-pushed
the
dantup/fix-at-file-search-relative
branch
from
eb27c16
to
c44f623
Compare
|
Hmm, there's something odd going on now. With this change, fail.mp4This is reliably reproducible for me, and feels like two bugs (non-matched items in the results, and the duplicated text). I might not get chance to look into this before Friday now, so if this is important and anyone else has time, feel free to take a look! |
lol, it very much as a |
|
I've filed #2243 about the bug. @dominiccooney heading off, but if you're happy with this as-is and the last bots go green feel free to merge :) |
[This depends on a function added in https://github.com//pull/2215 so this will fail bots until that lands and I rebase/merge]
Fixes #2208
Test plan
pnpm test:e2e at-fileto run the updated test, or@but type part of the file path outside of the folder opened in VS Code (eg. if you haveC:\Source\cody\ open, typesource`)sourceexists in their full fspaths