New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test validates instance #687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwedeportivo
requested review from
a team,
slimsag,
davejrt,
daxmc99,
ggilmore and
bobheadxi
June 30, 2020 23:17
bobheadxi
reviewed
Jul 1, 2020
This was referenced Jul 1, 2020
slimsag
added this to Medium priority (ordered)
in OLD - Distribution - use "Distribution 🚢"
Jul 1, 2020
56 tasks
ok, switched to json spec for validation, give it another look |
bobheadxi
approved these changes
Jul 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool!
daxmc99
approved these changes
Jul 20, 2020
slimsag
approved these changes
Aug 11, 2020
…rcegraph into validate_instance
OLD - Distribution - use "Distribution 🚢"
automation
moved this from Medium priority (ordered)
to Done
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a validation step to a test run that also uses gitserver ssh keys
implements sourcegraph/sourcegraph#9722
companion PR sourcegraph/src-cli#200