Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test validates instance #687

Merged
merged 31 commits into from Nov 10, 2020
Merged

test validates instance #687

merged 31 commits into from Nov 10, 2020

Conversation

uwedeportivo
Copy link
Contributor

@uwedeportivo uwedeportivo commented May 14, 2020

adds a validation step to a test run that also uses gitserver ssh keys

implements sourcegraph/sourcegraph#9722

companion PR sourcegraph/src-cli#200

@uwedeportivo uwedeportivo marked this pull request as draft May 14, 2020 18:54
@uwedeportivo uwedeportivo marked this pull request as ready for review June 30, 2020 23:17
tests/integration/restricted/test.sh Outdated Show resolved Hide resolved
tests/integration/restricted/validate.star Outdated Show resolved Hide resolved
@uwedeportivo
Copy link
Contributor Author

ok, switched to json spec for validation, give it another look

Copy link
Member

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

@uwedeportivo uwedeportivo merged commit a8bd7c4 into master Nov 10, 2020
OLD - Distribution - use "Distribution 🚢" automation moved this from Medium priority (ordered) to Done Nov 10, 2020
@uwedeportivo uwedeportivo deleted the validate_instance branch November 10, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
4 participants