Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

refactor: git and config logic to separate file #16

Merged
merged 2 commits into from
Sep 16, 2018
Merged

refactor: git and config logic to separate file #16

merged 2 commits into from
Sep 16, 2018

Conversation

nicksnyder
Copy link
Contributor

@nicksnyder nicksnyder commented Sep 16, 2018

factored out of #15

@nicksnyder nicksnyder mentioned this pull request Sep 16, 2018
5 tasks
@nicksnyder nicksnyder changed the title refactor: git logic to separate file refactor: git and config logic to separate file Sep 16, 2018
Copy link
Member

@slimsag slimsag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚢

@@ -0,0 +1,11 @@
'use strict'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slimsag @felixfbecker is this useful/necessary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/31391760/use-strict-needed-in-a-typescript-file

We should enable the always strict TS compiler flag I guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17

@slimsag
Copy link
Member

slimsag commented Sep 16, 2018

Merging

@slimsag slimsag merged commit 6f0f4d1 into master Sep 16, 2018
@slimsag slimsag deleted the refactor branch September 16, 2018 01:30
@sourcegraph-bot
Copy link

🎉 This PR is included in version 1.0.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants