refactor: be strict #17
Conversation
| @@ -7,7 +7,8 @@ | |||
| "lib": ["es6"], | |||
| "sourceMap": true, | |||
| "rootDir": "src", | |||
| "esModuleInterop": true | |||
| "esModuleInterop": true, | |||
| "strict": true | |||
There was a problem hiding this comment.
This flag does not mean ‘use strict’ mode. It enables strict TypeScript compile settings, which we already enable through our shared tsconfig, so this should have no effect (if it does, we should add it to the shared tsconfig instead)
There was a problem hiding this comment.
I think what you meant was alwaysStrict, but it should be added to the shared config.
There was a problem hiding this comment.
strict implies alwaysStrict according to this:
https://www.typescriptlang.org/docs/handbook/compiler-options.html
It was already generating js that contained 'use strict' before this, but being strict seems like a good idea anyway. I didn't remember that we had a shared config.
|
🎉 This PR is included in version 1.0.13 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.