remove autoFocus prop

sourcegraph · Jan 15, 2019 · 93eada0 · 93eada0
1 parent 73a1b5e
commit 93eada0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/client/browser/src/libs/code_intelligence/extensions.tsx b/client/browser/src/libs/code_intelligence/extensions.tsx
@@ -47,7 +47,6 @@ export function initializeExtensions({
                         extensionsController={extensionsController}
                         menu={ContributableMenu.CommandPalette}
                         platformContext={platformContext}
-                        autoFocus={false}
                         location={history.location}
                     />
                     <Notifications extensionsController={extensionsController} />

diff --git a/shared/src/commandPalette/CommandList.tsx b/shared/src/commandPalette/CommandList.tsx
@@ -21,9 +21,6 @@ interface Props extends ExtensionsControllerProps, PlatformContextProps {
     /** Called when the user has selected an item in the list. */
     onSelect?: () => void
 
-    /** Whether the text input should have autofocus. */
-    autoFocus: boolean
-
     location: H.Location
 }
 
@@ -89,11 +86,9 @@ export class CommandList extends React.PureComponent<Props, State> {
         )
 
         // Only focus input after it has been rendered in the DOM
-        if (this.props.autoFocus) {
-            setTimeout(() => {
-                this.setState({ autoFocus: true })
-            })
-        }
+        setTimeout(() => {
+            this.setState({ autoFocus: true })
+        })
     }
 
     public componentDidUpdate(_prevProps: Props, prevState: State): void {

diff --git a/web/src/nav/NavLinks.tsx b/web/src/nav/NavLinks.tsx
@@ -97,7 +97,6 @@ export class NavLinks extends React.PureComponent<Props> {
                     extensionsController={this.props.extensionsController}
                     platformContext={this.props.platformContext}
                     toggleVisibilityKeybinding={this.props.keybindings.commandPalette}
-                    autoFocus={true}
                     location={this.props.location}
                 />
                 {this.props.authenticatedUser && (