Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dots in usernames rejected in user settings frontend #4909

Closed
dadlerj opened this issue Jul 16, 2019 · 0 comments · Fixed by #4925
Closed

Dots in usernames rejected in user settings frontend #4909

dadlerj opened this issue Jul 16, 2019 · 0 comments · Fixed by #4925
Assignees
@tsenart
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.

Comments

@dadlerj
Copy link
Member

dadlerj commented Jul 16, 2019

  • Sourcegraph version: SGdev

In #4690, we made it possible to create usernames from SSO signups that include dots. It's still not possible to change your username to include a dot in the UI though.

Steps to reproduce:

  1. Visit your User settings > Profile
  2. Try to change your username to add a dot
  3. See the error below

image
@dadlerj dadlerj added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. team/core-services labels Jul 16, 2019
tsenart added a commit that referenced this issue Jul 17, 2019
@tsenart
Allow creating and updating (user|org) names with dots
b348857 
In #4690, we made it possible to create usernames from SSO signups that include dots.

But it was still not possible to change or manually create an account with a username that
includes a dot in the UI. This PR fixes that.

For consistency, we allow dots in org names too.

Fixes #4909, #4920
@tsenart tsenart mentioned this issue Jul 17, 2019
Merged
tsenart added a commit that referenced this issue Jul 17, 2019
@tsenart
Allow creating and updating (user|org) names with dots (#4925)
992aa56 
In #4690, we made it possible to create usernames from SSO signups that include dots. But that would have failed, as I found out working on this, due to a database constraint that needed to be updated.

Additionally, it was still not possible to change or manually create an account with a username that
includes a dot in the UI. This PR fixes that too.

For consistency, we allow dots in org names as well.

Fixes #4909, #4920
keegancsmith pushed a commit that referenced this issue Jul 17, 2019
@tsenart @keegancsmith
Allow creating and updating (user|org) names with dots (#4925)
835b768 
In #4690, we made it possible to create usernames from SSO signups that include dots. But that would have failed, as I found out working on this, due to a database constraint that needed to be updated.

Additionally, it was still not possible to change or manually create an account with a username that
includes a dot in the UI. This PR fixes that too.

For consistency, we allow dots in org names as well.

Fixes #4909, #4920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsenart tsenart

Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow creating and updating (user|org) names with dots sourcegraph/sourcegraph
2 participants
@tsenart @dadlerj