auth: Allow '.' in NormalizeUsername #4690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
approved these changes
Jun 28, 2019
sqs
approved these changes
Jun 28, 2019
Co-Authored-By: Quinn Slack <qslack@qslack.com>
Codecov Report
@@ Coverage Diff @@
## master #4690 +/- ##
==========================================
+ Coverage 47.83% 47.83% +<.01%
==========================================
Files 725 725
Lines 44235 44235
Branches 1758 1758
==========================================
+ Hits 21158 21160 +2
+ Misses 21084 21083 -1
+ Partials 1993 1992 -1
|
slimsag
pushed a commit
that referenced
this pull request
Jul 2, 2019
* auth: Allow '.' in NormalizeUsername Fixes #4674 * Update CHANGELOG * Update CHANGELOG.md Co-Authored-By: Quinn Slack <qslack@qslack.com> * fixup! Fix TestMiddleware
tsenart
added a commit
that referenced
this pull request
Jul 17, 2019
In #4690, we made it possible to create usernames from SSO signups that include dots. But that would have failed, as I found out working on this, due to a database constraint that needed to be updated. Additionally, it was still not possible to change or manually create an account with a username that includes a dot in the UI. This PR fixes that too. For consistency, we allow dots in org names as well. Fixes #4909, #4920
keegancsmith
pushed a commit
that referenced
this pull request
Jul 17, 2019
In #4690, we made it possible to create usernames from SSO signups that include dots. But that would have failed, as I found out working on this, due to a database constraint that needed to be updated. Additionally, it was still not possible to change or manually create an account with a username that includes a dot in the UI. This PR fixes that too. For consistency, we allow dots in org names as well. Fixes #4909, #4920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4674