Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing prometheus metrics #6428

Closed
3 of 13 tasks
slimsag opened this issue Nov 5, 2019 · 7 comments
Closed
3 of 13 tasks

Missing prometheus metrics #6428

slimsag opened this issue Nov 5, 2019 · 7 comments
Assignees
Milestone

Comments

@slimsag
Copy link
Member

slimsag commented Nov 5, 2019

This is a list of metrics that do not exist and would be helpful in debugging customer issues:

  • # of repositories that are indexed, unindexed, indexing
  • repo cloning
    • # of repositories that are cloning -> src_gitserver_clone_queue
    • # of repositories that have cloned since gitserver started -> src_gitserver_clone_queue
    • # of repositories that are not cloned on the instance overall
    • # of repositories that are cloned on the instance overall
  • Total memory & CPU available to container/host-machine in sourcegraph/server deployments
  • Network / disk IO in sourcegraph/server deployments
  • # of HTTP requests made to Sourcegraph by status code (src_http_request_duration_seconds is a histogram and has src_http_request_duration_seconds_count)
  • # of GraphQL requests made by (type, field) -- current histogram doesn't cover this
  • # of searches hitting zoekt vs. searcher
  • # of symbol searches hitting zoekt vs. symbols
  • # of diff/commit searches
  • # of searches hitting indexed vs. unindexed branches
@uwedeportivo
Copy link
Contributor

uwedeportivo commented Nov 7, 2019

number of repositories that are cloned, not cloned, cloning:

src_gitserver_repo_cloned, src_gitserver_clone_queue

@slimsag
Copy link
Member Author

slimsag commented Nov 7, 2019

src_gitserver_repo_cloned appears to be the number of repos that have been cloned since gitserver started, not the # that are cloned on the instance period

image

@slimsag
Copy link
Member Author

slimsag commented Nov 7, 2019

I broke out that section into four bullets to indicate the two missing metrics

@uwedeportivo
Copy link
Contributor

Cool, thanks

@uwedeportivo
Copy link
Contributor

each histogram has a counter: src_http_request_duration_seconds_count should do it.

@slimsag
Copy link
Member Author

slimsag commented Nov 7, 2019

Nice, we should perhaps declare rules to make that more obvious, so that src_http_request_count maps to that for each relevant histogram?

@slimsag
Copy link
Member Author

slimsag commented Apr 14, 2020

Closing this issue.

of repositories that are indexed, unindexed, indexing

Superseded by:

of repositories that are not cloned on the instance overall

Superseded by #9837

of repositories that are cloned on the instance overall

Not useful / can't be alerted on.

  • Total memory & CPU available to container/host-machine in sourcegraph/server deployments
  • Network / disk IO in sourcegraph/server deployments

No longer a goal with Docker Compose deployments existing.

of GraphQL requests made by (type, field)

Superseded by #9797

  • of searches hitting zoekt vs. searcher

  • of symbol searches hitting zoekt vs. symbols

Superseded by #9838

of diff/commit searches

Superseded by #9744

of searches hitting indexed vs. unindexed branches

Superseded by #9838

that are cloned on the instance period

Already present in new monitoring via clone queue size (which effectively communicates the same thing).

@slimsag slimsag closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants