Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking-issue: Implement simplified workflow #10157

Merged
merged 3 commits into from Apr 23, 2020

Conversation

tsenart
Copy link
Contributor

@tsenart tsenart commented Apr 23, 2020

This PR changes the tracking-issue tool to simplify how we create tracking issues and have them be automatically updated.

Before, changing which tracking issues are automatically updated required a change and pull request to the "Tracking Issue Syncer" GitHub Action definition. This needed to happen on every milestone change, for instance.

With this change, the tool instead finds all open tracking issues in the sourcegraph repo that have the tracking label, searches for all their issues and PRs (that have the rest of the labels in the tracking issue), and updates them automatically when there are modifications.

Additionally, this change set also makes it possible for tracking issues to be created for any other label, even if the tracking issue isn't bound to a milestone. This allows us to have tracking issues for things like RFCs, OKRs, etc. cc @nicksnyder

All of this will be documented properly in sourcegraph/about#786.

@tsenart tsenart added this to the 3.16 milestone Apr 23, 2020
@tsenart tsenart requested a review from slimsag as a code owner April 23, 2020 16:14
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #10157 into master will decrease coverage by 0.00%.
The diff coverage is 15.06%.

@@            Coverage Diff             @@
##           master   #10157      +/-   ##
==========================================
- Coverage   42.74%   42.73%   -0.01%     
==========================================
  Files        1348     1348              
  Lines       73986    73998      +12     
  Branches     6649     6649              
==========================================
+ Hits        31623    31625       +2     
- Misses      39503    39514      +11     
+ Partials     2860     2859       -1     
Flag Coverage Δ
#unit 42.73% <15.06%> (-0.01%) ⬇️
Impacted Files Coverage Δ
internal/cmd/tracking-issue/main.go 34.47% <15.06%> (-0.51%) ⬇️

@tsenart tsenart merged commit ffc3619 into master Apr 23, 2020
@tsenart tsenart deleted the tracking-issue/dynamic-selection branch April 23, 2020 16:15
notjrbauer pushed a commit to notjrbauer/sourcegraph that referenced this pull request Apr 25, 2020
* Dynamic selection of tracking issues

* fixup! Update tracking issues in one go

* fixup! Done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant