New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external services UI #1103

Merged
merged 25 commits into from Dec 6, 2018

Conversation

Projects
None yet
7 participants
@nicksnyder
Copy link
Member

nicksnyder commented Nov 21, 2018

Part of #914
screen recording 2018-11-27 at 11 40 pm

@nicksnyder nicksnyder force-pushed the extsvcui branch from a119174 to 2ad89bf Nov 21, 2018

@nicksnyder nicksnyder requested a review from beyang as a code owner Nov 22, 2018

@nicksnyder nicksnyder force-pushed the extsvcui branch from 6888063 to f17f5ce Nov 26, 2018

@nicksnyder nicksnyder force-pushed the extsvcui branch from dfdbff3 to 8c66ce3 Nov 27, 2018

@nicksnyder nicksnyder force-pushed the extsvcui branch 2 times, most recently from a0d1861 to 7bd38d2 Nov 27, 2018

@nicksnyder nicksnyder removed the request for review from beyang Nov 28, 2018

@nicksnyder nicksnyder force-pushed the extsvcui branch from 7bd38d2 to 6caff84 Nov 28, 2018

@nicksnyder nicksnyder changed the title wip: external services UI external services UI Nov 28, 2018

@nicksnyder nicksnyder requested review from slimsag and felixfbecker Nov 28, 2018

@nicksnyder

This comment has been minimized.

Copy link
Member Author

nicksnyder commented Nov 28, 2018

I would like to merge this today but I assume there will be review comments. Please be clear about which comments you think block merging.

In the very short term this UI will use useful in dogfood and sourcegraph.com to help me migrate.

@felixfbecker

This comment has been minimized.

Copy link
Member

felixfbecker commented Nov 28, 2018

What is an "external service"? Is it a code host? Or what else can it "service"?

@nicksnyder

This comment has been minimized.

Copy link
Member Author

nicksnyder commented Nov 28, 2018

Yes, they are basically code hosts for now. See #1077 (comment)

@slimsag

This comment has been minimized.

Copy link
Member

slimsag commented Nov 28, 2018

+1 Nice

@dadlerj

This comment has been minimized.

Copy link
Member

dadlerj commented Nov 28, 2018

Sorry I haven't been involved in this project at all, but I'm a bit confused. Is this replacing having code host connections in site config? Or will there just be two UIs for adding them now?

@slimsag

This comment has been minimized.

Copy link
Member

slimsag commented Nov 28, 2018

@dadlerj it is the replacement long term, but I think temporarily we will have both (not sure what we will have for 3.0 preview though)

@nicksnyder

This comment has been minimized.

Copy link
Member Author

nicksnyder commented Nov 28, 2018

Is this replacing having code host connections in site config?

Yes, we are moving this out of site config. Users will never be in a state where there are two sources of truth.

@sqs sqs added the roadmap label Dec 4, 2018

@sqs sqs added this to the 3.0-preview milestone Dec 4, 2018

@nicksnyder nicksnyder force-pushed the extsvcui branch from d03c55f to ab95092 Dec 4, 2018

@nicksnyder nicksnyder referenced this pull request Dec 4, 2018

Merged

constant extra schemas #1225

@nicksnyder

This comment has been minimized.

Copy link
Member Author

nicksnyder commented Dec 4, 2018

@felixfbecker can you review my resolutions to your comments?

nicksnyder added some commits Dec 4, 2018

},
].concat(extraSchemas),
})
setDiagnosticsOptions(monaco, this.props)

This comment has been minimized.

@felixfbecker

felixfbecker Dec 6, 2018

Member

Above you use this.monaco, here you use monaco. I think you need to use this.monaco everywhere in all value positions or else monaco will not be lazy-loaded but bundled into the main bundle. The import monaco is only for the type I think. To prevent these mistakes I usually do something like

import * as _monaco from 'monaco'
type Monaco = typeof _monaco // Type only!

With the underscore making it clear that this should not be used anywhere.

This comment has been minimized.

@felixfbecker

felixfbecker Dec 6, 2018

Member

There's also now TS import types which can import a type without creating a value binding:

interface State {
  monaco: import('monaco'),
}

This comment has been minimized.

@nicksnyder

nicksnyder Dec 6, 2018

Author Member

monaco is just a pre-existing variable that is assigned on L144, so I don't think I have changed any semantics with respect to how monaco is imported here.

nicksnyder added some commits Dec 6, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #1103 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted Files Coverage Δ
cmd/frontend/graphqlbackend/external_services.go 0% <0%> (ø) ⬆️
cmd/frontend/db/external_services.go 0% <0%> (ø) ⬆️
pkg/search/backend/backend.go 97.29% <0%> (-2.71%) ⬇️

@nicksnyder nicksnyder merged commit 74d92eb into master Dec 6, 2018

1 check passed

buildkite/sourcegraph Build #24911 passed (5 minutes, 13 seconds)
Details

@nicksnyder nicksnyder deleted the extsvcui branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment