Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ConfigurationRawJSON -> Configuration #1168

Merged
merged 2 commits into from Nov 29, 2018
Merged

Conversation

slimsag
Copy link
Member

@slimsag slimsag commented Nov 29, 2018

In the near future this will return a data structure and the name suffix
RawJSON no longer makes sense in that context. I am reducing the size of my
other PR's diff, and as such merging this separately.

In the near future this will return a data structure and the name suffix
`RawJSON` no longer makes sense in that context. I am reducing the size of my
other PR's diff, and as such merging this separately.
@slimsag slimsag requested a review from beyang as a code owner November 29, 2018 02:10
@codecov-io
Copy link

Codecov Report

Merging #1168 into master will decrease coverage by 0.25%.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/conf/client.go 14.81% <0%> (+0.26%) ⬆️
cmd/frontend/internal/httpapi/internal.go 0% <0%> (ø) ⬆️
cmd/frontend/internal/httpapi/httpapi.go 19.1% <0%> (ø) ⬆️
cmd/frontend/auth/providers.go 0% <0%> (-25.81%) ⬇️
cmd/frontend/internal/authz/register.go 0% <0%> (-14.29%) ⬇️
cmd/frontend/registry/backcompat.go 13.04% <0%> (-4.67%) ⬇️
pkg/gosrc/import_path.go 87.75% <0%> (-1.64%) ⬇️
pkg/diskcache/cache.go 42.6% <0%> (-0.99%) ⬇️
enterprise/cmd/xlang-go/internal/server/deps.go 80.85% <0%> (-0.86%) ⬇️
enterprise/cmd/frontend/auth/githuboauth/config.go 33.33% <0%> (-0.6%) ⬇️
... and 13 more

@slimsag slimsag merged commit 54b1183 into master Nov 29, 2018
@slimsag slimsag deleted the sg/httpapi-config branch November 29, 2018 02:31
@slimsag
Copy link
Member Author

slimsag commented Nov 29, 2018

Helps #965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants